Added word break when notification title too Long #15447
Conversation
|
Hi, thanks for your contribution! |
|
I think we should elide the text instead, the hover will reveal the whole text. Otherwise, if there is some description the now wrapped title will cover it. |
I also have encountered a case like this , in this case eliding the text will not work and can cause confusion to the user if the user's first name is elided and rest of the content is not what do you recommend here @saghul |
|
That one could be elided in the middle to the user sees someone joined. |
you meant something like this right ? "wilson..... and when hover on it, show the tooltip ? |
|
Yeah that's right! |
@saghul I have pushed the changes , could you please review it ? :) |
lint fix lint fix lint fix refactor lint fix modified elide logic changed words lint fix lint fix lint fix fix(polls) improve resilience to bogus data feat(tests): Adds self view, display name and end conference tests. (jitsi#15432) * feat(tests): Use shorter display names for screenshots. * feat(tests): Adds self view tests. * feat(tests): Adds display name test. * feat(tests): Adds end conference test. fix(configWhitelist): Remove some props. chore(deps) lib-jitsi-meet@latest jitsi/lib-jitsi-meet@v1890.0.0+144b0cab...v1893.0.0+496b64a7 fix(connection): Adds default tenant value on error. Avoids undefined error. feat(customParticipantButton): metrics fix(lang) fix typo in unsecure room name warning (jitsi#15468) fix(video-menu): Hide "Mute all" option when all participants are moderators (jitsi#15461) * Fixed exception for visibility state of mute all button * Updated changes as per review: shifted conditional to the toggle * chore: fix eslint warnings and errors --------- Co-authored-by: Bhavik Arora <arorabhavik1001> fix(readme): Fixes badge icon and f-droid link. Fixes jitsi#15464 Fixes jitsi#15465 chore(deps) lib-jitsi-meet@latest jitsi/lib-jitsi-meet@v1893.0.0+496b64a7...v1895.0.0+7de7d9aa fix(readme): Fixes badge icon. Fixes jitsi#15464 lang: Update main-zhCN.json (jitsi#15426) main-zhCN.json line 413 missing: "sessTerminatedReason": "会议已经结束", feat(tests): Adds desktop sharing test. feat(tests): Adds dial-in test. (jitsi#15470) * feat(tests): Adds dial-in test. * feat(tests): Adds fake dial-in test. * squash: switch to performance.now(). fix(polls) limit maximum amount of answers chore(helpers) drop custom createDeferred() for Promise.withResolvers() chore(deps) update eslint Required for compatibility with new TypeScript plugins. fix(lint) tame linter feat(tests): Adds follow-me and invite dialog test. (jitsi#15476) * feat(tests): Adds follow-me test. * feat(tests): Adds invite dialog test. * squash: fix lint. fix(configWhitelist): Add p2p.mobileScreenshareCodec refined logic remove tooltip cleaup Update Notification.tsx lint fix
5f8374b to
a46f620
Compare
c32acba to
3be97eb
Compare
#15448
Added word breaking for overly long notification titles, following language-specific rules. In some languages, a hyphen is inserted at the line break, while others continue onto the next line without a hyphen, unlike in English.
Result:
Screen.Recording.2025-01-12.at.10.04.55.PM.online-video-cutter.com.mp4