Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ConcurrentModificationException. #984

Merged
merged 4 commits into from
Oct 3, 2022

Conversation

bgrozev
Copy link
Member

@bgrozev bgrozev commented Oct 3, 2022

  • Fix/supress warnings.
  • fix: Set XML parsing settings.
  • ref: Reuse ParticipantInfo.toEndpoint.
  • fix: Fix ConcurrentModificationException when bridge count changes.

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Merging #984 (45d3ee7) into master (21c4a3c) will increase coverage by 0.35%.
The diff coverage is 60.86%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #984      +/-   ##
============================================
+ Coverage     31.19%   31.54%   +0.35%     
- Complexity      523      533      +10     
============================================
  Files           116      116              
  Lines          7010     7008       -2     
  Branches        960      955       -5     
============================================
+ Hits           2187     2211      +24     
+ Misses         4558     4537      -21     
+ Partials        265      260       -5     
Impacted Files Coverage Δ
...otlin/org/jitsi/jicofo/conference/source/Source.kt 0.00% <0.00%> (ø)
...org/jitsi/jicofo/bridge/colibri/Colibri2Session.kt 0.00% <0.00%> (ø)
...tlin/org/jitsi/jicofo/bridge/colibri/Extensions.kt 0.00% <0.00%> (ø)
...ofo/src/main/java/org/jitsi/jicofo/rest/Debug.java 0.00% <ø> (ø)
...main/kotlin/org/jitsi/jicofo/xmpp/MuteIqHandler.kt 19.27% <0.00%> (ø)
...tsi/jicofo/conference/JitsiMeetConferenceImpl.java 48.20% <88.88%> (+0.93%) ⬆️
...ofo/src/main/kotlin/org/jitsi/jicofo/xmpp/Smack.kt 100.00% <100.00%> (ø)
...o/src/main/kotlin/org/jitsi/jicofo/FocusManager.kt 61.53% <0.00%> (+0.96%) ⬆️
.../java/org/jitsi/jicofo/conference/Participant.java 74.83% <0.00%> (+2.58%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e258e1...45d3ee7. Read the comment docs.

@bgrozev bgrozev merged commit 6537921 into jitsi:master Oct 3, 2022
@bgrozev bgrozev deleted the fix-concurrent-modification-exception branch January 25, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants