Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update smack. #979

Merged
merged 4 commits into from
Sep 28, 2022
Merged

chore: Update smack. #979

merged 4 commits into from
Sep 28, 2022

Conversation

bgrozev
Copy link
Member

@bgrozev bgrozev commented Sep 27, 2022

No description provided.

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #979 (d6d9e76) into master (0eb385f) will increase coverage by 0.18%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #979      +/-   ##
============================================
+ Coverage     31.19%   31.38%   +0.18%     
- Complexity      523      530       +7     
============================================
  Files           116      116              
  Lines          7010     7010              
  Branches        961      960       -1     
============================================
+ Hits           2187     2200      +13     
+ Misses         4558     4549       -9     
+ Partials        265      261       -4     
Impacted Files Coverage Δ
...ava/org/jitsi/impl/protocol/xmpp/ChatRoomImpl.java 0.00% <0.00%> (ø)
...tsi/jicofo/conference/JitsiMeetConferenceImpl.java 47.98% <0.00%> (+0.71%) ⬆️
...otlin/org/jitsi/jicofo/xmpp/AvModerationHandler.kt 29.23% <0.00%> (+0.87%) ⬆️
.../java/org/jitsi/jicofo/conference/Participant.java 74.19% <0.00%> (+1.93%) ⬆️
...i/jicofo/conference/ParticipantInviteRunnable.java 49.35% <0.00%> (+3.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0eb385f...d6d9e76. Read the comment docs.

@@ -86,7 +86,7 @@
/**
* Listener for presence that smack sends on our behalf.
*/
private PresenceListener presenceInterceptor;
private org.jivesoftware.smack.util.Consumer<PresenceBuilder> presenceInterceptor;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be imported?

@bgrozev
Copy link
Member Author

bgrozev commented Sep 28, 2022

test failures unrelated

@bgrozev bgrozev merged commit 21c4a3c into jitsi:master Sep 28, 2022
@bgrozev bgrozev deleted the update-smack branch January 25, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants