Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of Jibri busy response #659

Merged
merged 2 commits into from
Jan 7, 2021
Merged

Conversation

bbaldino
Copy link
Member

@bbaldino bbaldino commented Jan 6, 2021

This PR aims to address the following issue:

  • Call A starts a recording, Jibri 1 is selected
  • Call B starts a recording, Jibri 1 was selected (Jicofo didn't see it as busy yet)
  • Call A's JibriSession gets a pending response
  • Call B's JibriSession gets a busy response
  • Jicofo treats any response that's not pending to a Jibri request as an error, so we now consider Jibri 1 in an error state
  • Jicofo removes and re-adds Jibri 1 to the MUC in order to move it to the back of the line
  • Call A's JibriSession sees the Jibri leave the MUC, so sends an error to the client (thinking Jibri went away)

The fix was to not treat the busy response as a transient error.

@bbaldino bbaldino merged commit 137c67e into jitsi:master Jan 7, 2021
@bbaldino bbaldino deleted the jibri_fix branch January 7, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants