Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bitrate instead of videostreams for load balancing. #358

Merged
merged 2 commits into from
May 9, 2019

Conversation

bgrozev
Copy link
Member

@bgrozev bgrozev commented May 9, 2019

No description provided.

@bgrozev bgrozev force-pushed the load-balance-bitrate branch from 159ade2 to 8bf8155 Compare May 9, 2019 16:11
damencho
damencho previously approved these changes May 9, 2019
@paweldomas
Copy link
Member

If we know it's a better metric and will not be going back to video streams, maybe we should get rid of the logics for estimating the video stream count ?

@bgrozev
Copy link
Member Author

bgrozev commented May 9, 2019

I think that makes sense, Pawel. But let's take a look at how well this works first. I'll add this to my list

@paweldomas
Copy link
Member

paweldomas commented May 9, 2019

Btw. is the bitrate statistic relatively consistent over time ? Im wondering if there are any big variations over short periods of time.

Also I suspect it may not behave perfectly when starting up a lot of conferences/participants at the same time. That's why the "video stream" estimation was introduced, to handle well bursts of channel allocations

@paweldomas
Copy link
Member

I don't remember though why handling burst of channels was important. One case I can think of is conference migration when bridge goes down, but it's a corner case.

@bgrozev
Copy link
Member Author

bgrozev commented May 9, 2019

Screenshot 2019-05-09 at 17 28 33

It seems pretty stable. We get updated stats every 5 seconds, so it should be fine

@bgrozev
Copy link
Member Author

bgrozev commented May 9, 2019

One case I can think of is conference migration when bridge goes down, but it's a corner case.

Oh, yes, that's a good point!

@bgrozev bgrozev merged commit fbd80c5 into master May 9, 2019
@paweldomas paweldomas deleted the load-balance-bitrate branch April 29, 2020 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants