Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release + binary upload for tags #14

Merged
merged 8 commits into from
Nov 11, 2021
Merged

Add release + binary upload for tags #14

merged 8 commits into from
Nov 11, 2021

Conversation

jisantuc
Copy link
Owner

@jisantuc jisantuc commented Nov 10, 2021

This PR uses the nix-store to determine the absolute path to the built binary instead of just using which cliffs. which cliffs in a nix environment resolves to the link. In linux you can use readlink -f to canonicalize the link, but that was never going to work for the mac build, but nix-store -r resolves the root of the derivation in linux and macos.

You can see a successfully built release artifacts here

Closes #8

@jisantuc jisantuc changed the title [wip] Add release + binary upload for tags Add release + binary upload for tags Nov 11, 2021
@jisantuc jisantuc merged commit 310e1af into main Nov 11, 2021
@jisantuc jisantuc deleted the feature/js/add-cd branch November 11, 2021 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CD
1 participant