Add unlink statistics behind an -x flag #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the two other fields ZFS exposes: nunlinked, the number of files unlinked from the filesystem, and nunlinks, which includes the number that have been queued. Add an -x flag for extended statistics. Hide both opsize and nunlinks by default to make for a clear display, with -x to add opsize and -xx to add both that and unlink statistics.
|
Adding unlinks seems sensible, given they're the other values ZFS sees fit to expose. What do we think about the flag usage, though? Hiding |
Instead of columns having a title and an implicit index, give columns an explicit key from which to uniquely identify them. Replace print_columns() with add_row() using keys to identify column data. This decouples column ordering from most of the code.
Instead of using parameters to a slice and making assumptions about column order, teach get_printed_width to exclude a list of named columns from its calculation regardless of their position. While here, hoist the calculation outside the main loop since these values aren't dynamic.
Set COLUMNS=80 for generating help text for README, and tweak descriptions to fit more tidily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the two other fields ZFS exposes: nunlinked, the number of files
unlinked from the filesystem, and nunlinks, which includes the number
that have been queued.
Add an -x flag for extended statistics. Hide both opsize and nunlinks
by default to make for a clear display, with -x to add opsize and -xx to
add both that and unlink statistics.