Add [interval [count]] positional arguments #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is traditional iostat argument style, so it seems sensible to support it ourselves. Also, as is tradition, default to a count of 1, so only the initial summary is shown.
Add skip_iter and take_iter functions which skip n/yield at most n elements from an iterator, and replace islice with them. This makes the diff_loop setup tidier and easier to reason about.
There's no need for this to be a generator - just let it pop off n iterations and return the original.
Restore interval as a float
This makes calc_name_width simpler, since it's not defining a new method inline.
Simplify some conditionals to avoid having to worry about None quite so much, and add a few comments to help explain why we're doing stuff.
Instead of setting dest to a wonky-but-hey-it-works value, suppress it entirely and override metavar instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
[interval [count]]positional arguments, and changes the default iteration count to 1, bringing it in line with other iostat-alikes.This involves a somewhat ugly hack with
argparse- we add a dummy positional namedinterval [count]which, thanks to the priordatasetpositional, will never be filled. We then extract them fromdatasetmanually after parsing.