Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a -z flag to suppress datasets with no activity #14

Merged
merged 2 commits into from
Jan 20, 2022

Conversation

Freaky
Copy link
Collaborator

@Freaky Freaky commented Jan 19, 2022

Fixes #12

This feels best combined with -s name, as the multi-line naming gets a bit too dynamic.

@Freaky
Copy link
Collaborator Author

Freaky commented Jan 19, 2022

Thoughts on making -s name default in this mode?

@jimsalterjrs jimsalterjrs merged commit d5e1cd1 into jimsalterjrs:main Jan 20, 2022
@jimsalterjrs
Copy link
Owner

Hmmm, there appears to have been a bug in this PR, if you tested after I merged all the others today:

me@banshee:/usr/local/bin$ sudo ioztat
  File "/usr/local/bin/ioztat", line 68
    header, _fieldnames, *fields = [line.split() for line in f]
                         ^
SyntaxError: invalid syntax

@jimsalterjrs
Copy link
Owner

well, it doesn't appear to have been this one--I'm seeing the breakage after reverting this as well.

@jimsalterjrs
Copy link
Owner

@Freaky I don't think I have much of an opinion about using -s name by default when -z is on. That seems fine to me. I suppose the question is whether people who want to opt out can specify a -s argument that brings back the default sorting?

Assuming the answer to the latter is "yes" I'd say you can go ahead and change the default sort when -z is on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFE to add -z
2 participants