Review Korean Translation #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cottonpup
commented
Jul 9, 2022
| @@ -81,15 +81,15 @@ | |||
| "Carousel": "캐러셀", | |||
| "Collapse": "접기", | |||
| "Countdown": "카운트다운", | |||
| "Kbd": "단축키", | |||
| "Kbd": "키보드", | |||
There was a problem hiding this comment.
이건 고민되었는데 방향키도 있는 컴포넌트라 단축키보단 키보드가 나을 거 같아서 변경했습니다.
| "Tooltip": "툴팁", | ||
| "Data input": "데이터 인풋", | ||
| "Checkbox": "체크박스", | ||
| "Text input": "텍스트 인풋", |
There was a problem hiding this comment.
툴팁은 개발자들에겐 툴팁이란 용어가 더 편한 거 같고 공식 리액트 한국어 문서에서도 툴팁이란 단어를 사용해서 변경해보았습니다.
데이터 인풋, 텍스트도 같은 이유입니다.
| @@ -160,9 +160,9 @@ | |||
| "But you can still customize components in many ways.": "하지만 여전히 여러 방법으로 컴포넌트를 커스터마이징 할 수 있습니다.", | |||
| "Let's say, you want to customize this button:": "이 버튼을 커스터마이징 하고 싶다면:", | |||
| "You can use daisyUI utility classes:": "데이지UI 유틸리티 클래스를 사용해 커스터마이징 할 수 있습니다:", | |||
| "You can use Tailwind's utility classes:": "Tailwind 유틸리티 클래스를 사용해 커스터마이징 할 수 있습니다:", | |||
| "You can use Tailwind's utility classes:": "Tailwind 유틸리티 클래스를 사용해 커스터마이징 할 수 있습니다.", | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 지효님!
띄어쓰기와 더 나은 번역에 있어서 의견을 내봤습니다.
한번 읽어보시고 확인 부탁드릴게요! :)