srcinfo package and protoc-gen-gosrcinfo #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
protoc-gen-gosrcinfo, a protoc plugin that allows file descriptors embedded in the Go program to include source code info. Theprotoc-gen-goplugin strips this info away, to reduce binary size and runtime memory footprint. But that means that user agents that use the gRPC server reflection service cannot access comments.In addition to the protoc plugin, this adds a package to support the runtime aspect as querying source code info for file descriptors, as well as an alternative implementation of server reflection that uses the runtime package in order to provide descriptors to clients that include source code info.