Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix $service_name in Debian distributions to use 'smartmontools' #32

Closed
wants to merge 5 commits into from

Conversation

TheLQ
Copy link

@TheLQ TheLQ commented Jun 25, 2014

@jhoblitt
Copy link
Owner

@LordQuackstar Travis is failing because this PR uses whitespace that doesn't pass puppet-lint. Also, are you willing to add rspec coverage?

@TheLQ
Copy link
Author

TheLQ commented Jun 27, 2014

Got the tabs fixed but I don't know enough ruby to fix the tests and compile. The hardest part is spec/classes/smartd_spec.rb which hardcoded smartd as the service name. spec/system/smartd_spec.rb looks relatively easy to fix.

Sorry for not being able to help with that.

@jhoblitt jhoblitt closed this in 5554213 Aug 7, 2014
jhoblitt pushed a commit that referenced this pull request Aug 7, 2014
Added debian support and working tests. Closes #32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants