-
-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to use new website #1357
Conversation
✅ Deploy Preview for jhipster-site ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I tried to update the preview feature on Netlify to run
|
I set the |
@SvMak It looks like there's a plugin that generates the sitemap. Can you please compare the existing sitemap with the new one to ensure they have the same URLs? |
Yes, the sitemap is generated automatically. Ok I'll compare site maps. |
https://www.jhipster.tech/jdl/applications in the new sitemap these URLs have a trailing slash https://www.jhipster.tech/tips/004_tip_using_ms_sql_server.html the old sitemap only contains this URL and /tips/ tips has redirects in redirects.config.ts release pages also have html extension https://www.jhipster.tech/presentation - deleted https://www.jhipster.tech/cn/ - china website version https://www.jhipster.tech/association/ - this page is lost, I need to add it and the old sitemap is aliased www, would you like to add www to new sitemap? |
If I compare https://deploy-preview-1357--jhipster-site.netlify.app/association/ to https://www.jhipster.tech/association/, I see a few differences.
|
|
I'll be happy to fix it if you provide more information about the issues. |
If you compare the headings b/w old and new you'll see they don't match. The current one displays a link icon when you mouse over a heading, the new one is missing words in the headings and there is no link icon.
I'd prefer there is no trailing slash. Is it possible to change this behavior? If not, do we need to do redirects? @jdubois Can we test this in a staging environment that mimics production to see?
Can we make it so the old URLs with the extension work and default to no extension for the future? |
Would you like there to be no trailing slash for all links or just for some links?
I'll check it out and let you know |
Could you take a screenshot of the missing words, I think I checked the headers and overall I didn't change anything on the page |
Latest changes #1365
Yes, slug can be without trailing slash /2024/06/24/jhipster-release-8.6.0 or with trailing slash /2024/06/24/jhipster-release-8.6.0/ or with .html ext /2024/06/24/jhipster-release-8.6.0.html |
@SvMak Thanks for making the URLs match. Is there anything else we should do before pushing this to a staging environment? |
I believe a direct link to the association is fine. Is there a PR for this or has it already been integrated? I believe the translations can be removed. Please confirm @pascalgrimaud @jdubois. |
Thank you!
I'll make pr today Edit: Done in the #1366 |
@mraible Latest sitemap changes #1357 (comment) are in #1365, could you merge it please? |
Hello, we have 2 official translations, one for Chinese and one for Japanese. They both make a lot of sense: those countries have a lot of Java developers, and it's much easier to understand in your own language (I wrote a book on Spring in French for this exact reason!). |
I can still:
Until the translation issue is resolved |
Can we keep the language switcher, at least for a few months? It’s all volunteer work, so it’s normal that things take time. |
Of course, to speed up the release of the new website, I propose one of the options:
Instead of removing all the functionality that was done in #1361 We can remove the translation functionality at any time if needed |
@mraible Yes, for old website internal links you must use {{ site.url }}, for new website you must use just relative path: I made a fix in #1368 |
From https://jhipster-website.netlify.app