Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add front JavaBase and SpringBoot buttons #953

Merged

Conversation

Franceq34
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Mar 7, 2022

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #953 (dd00d7b) into main (1587d9d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##                main      #953   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity      1327      1329    +2     
===========================================
  Files            252       252           
  Lines           4144      4161   +17     
  Branches          72        74    +2     
===========================================
+ Hits            4144      4161   +17     
Impacted Files Coverage Δ
...ebapp/app/generator/primary/Generator.component.ts 100.00% <100.00%> (ø)
...ebapp/app/generator/secondary/ProjectRepository.ts 100.00% <100.00%> (ø)
...va/tech/jhipster/lite/common/domain/FileUtils.java 100.00% <0.00%> (ø)
...frastructure/secondary/ProjectLocalRepository.java 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1587d9d...dd00d7b. Read the comment docs.

projectService.addJavaBase.resolves({});
await wrap({ projectService });

const mavenButton = wrapper.find('#javabase');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe rename to button, so it's simpler to duplicate test


const projectPathInput = wrapper.find('#path');
await projectPathInput.setValue(project.folder);
const mavenButton = wrapper.find('#javabase');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename to button

projectService.addSpringBoot.resolves({});
await wrap({ projectService });

const mavenButton = wrapper.find('#springboot');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename to button


const projectPathInput = wrapper.find('#path');
await projectPathInput.setValue(project.folder);
const mavenButton = wrapper.find('#springboot');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename to button

@Franceq34 Franceq34 force-pushed the add-front-java-spring-boot-buttons branch from 03dac96 to 302ed76 Compare March 8, 2022 08:23
@Franceq34 Franceq34 requested a review from pascalgrimaud March 8, 2022 08:24
@Franceq34 Franceq34 force-pushed the add-front-java-spring-boot-buttons branch from 302ed76 to dd00d7b Compare March 8, 2022 08:25
@pascalgrimaud pascalgrimaud merged commit 9258e68 into jhipster:main Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants