Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generated-application: Executes integration tests with a configuration derived from application configuration #7104

Merged

Conversation

murdos
Copy link
Contributor

@murdos murdos commented Aug 4, 2023

Follow-up to #7103 - for generated applications

This make tests more reliable since they use a configuration that is more real. And this decrease maintenance burden of test configuration since it only contains configuration override through Spring test profile.

@murdos murdos force-pushed the generated-app/test-config-extends-main-config branch from fc81235 to 3c055dd Compare August 4, 2023 22:10
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (e78a6aa) 100.00% compared to head (b2a04f0) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##                main     #7104   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      2531      2531           
===========================================
  Files            665       665           
  Lines          11234     11207   -27     
  Branches         238       238           
===========================================
- Hits           11234     11207   -27     
Files Changed Coverage Δ
...ngboot/broker/kafka/domain/KafkaModuleFactory.java 100.00% <ø> (ø)
...customjhlite/domain/CustomJHLiteModuleFactory.java 100.00% <ø> (ø)
...abase/cassandra/domain/CassandraModuleFactory.java 100.00% <ø> (ø)
...he/domain/Hibernate2ndLevelCacheModuleFactory.java 100.00% <ø> (ø)
...abase/sqlcommon/domain/SQLCommonModuleBuilder.java 100.00% <ø> (ø)
...ation/liquibase/domain/LiquibaseModuleFactory.java 100.00% <ø> (ø)
...migration/mongock/domain/MongockModuleFactory.java 100.00% <ø> (ø)
...igrations/domain/Neo4jMigrationsModuleFactory.java 100.00% <ø> (ø)
...curity/oauth2/core/domain/OAuth2ModuleFactory.java 100.00% <ø> (ø)
...gboot/core/domain/SpringBootCoreModuleFactory.java 100.00% <100.00%> (ø)
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

DamnClin
DamnClin previously approved these changes Aug 14, 2023
Copy link
Collaborator

@DamnClin DamnClin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I created conflict with main (I got confuse between your PRs...)

…n derived from application configuration

This make tests more reliable since they use a configuration that is more real.
And this decrease maintenance burden of test configuration since it only contains configuration override through Spring test profile.
@murdos murdos force-pushed the generated-app/test-config-extends-main-config branch from 3c055dd to b2a04f0 Compare August 23, 2023 20:21
@murdos murdos merged commit 64b9fb7 into jhipster:main Aug 23, 2023
@murdos murdos deleted the generated-app/test-config-extends-main-config branch August 23, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants