Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettier xml #380

Merged
merged 3 commits into from
Dec 22, 2021
Merged

Prettier xml #380

merged 3 commits into from
Dec 22, 2021

Conversation

MSaguer
Copy link
Contributor

@MSaguer MSaguer commented Dec 21, 2021

To close #103

Prettier-xml added and called automatically during commit with default values

@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #380 (821ff3a) into main (affc8f7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##                main      #380   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       561       561           
===========================================
  Files             93        93           
  Lines           1781      1781           
  Branches          37        37           
===========================================
  Hits            1781      1781           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update affc8f7...821ff3a. Read the comment docs.

@pascalgrimaud
Copy link
Member

I don't understand how this plugin should work.
I changed the indentation in pom.xml :

image

But everything is well formated:

image

@MSaguer
Copy link
Contributor Author

MSaguer commented Dec 22, 2021 via email

@pascalgrimaud
Copy link
Member

@MSaguer : I found the issue. We need to add this property in .prettierrc file

diff --git a/.prettierrc b/.prettierrc
index 34b8d15..7c210c3 100644
--- a/.prettierrc
+++ b/.prettierrc
@@ -11,6 +11,9 @@ arrowParens: avoid
 # jsx and tsx rules:
 bracketSameLine: false
 
+# xml
+xmlWhitespaceSensitivity: ignore
+
 # java rules:
 overrides:
   - files: "*.java"

package.json Outdated
"husky": "7.0.4",
"lint-staged": "12.1.3",
"prettier": "2.5.1",
"prettier": "^2.5.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"prettier": "^2.5.1",
"prettier": "2.5.1",

@pascalgrimaud pascalgrimaud merged commit 25e5360 into jhipster:main Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prettier XML
2 participants