Fix Code smells #364
Merged
Fix Code smells #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalgrimaud
commented
Dec 21, 2021
| @@ -217,7 +217,7 @@ public static String getPlugin(Plugin plugin, int indentation) { | |||
| plugin | |||
| .getAdditionalElements() | |||
| .ifPresent(additionalElements -> | |||
| result.append(plugin.getAdditionalElements().get().indent(4 * indentation).replaceAll("\n", System.lineSeparator())) | |||
| result.append(plugin.getAdditionalElements().get().indent(4 * indentation).replace("\n", System.lineSeparator())) | |||
There was a problem hiding this comment.
@swarajsaaj : just apply this fix for Sonar code smell. Can you check quickly if it's correct plz?
There was a problem hiding this comment.
Yes this seems to work fine.
Codecov Report
@@ Coverage Diff @@
## main #364 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 550 550
===========================================
Files 93 93
Lines 1777 1777
Branches 37 37
===========================================
Hits 1777 1777
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.