Mvn delete #318
Merged
Mvn delete #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## main #318 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 456 461 +5
===========================================
Files 80 80
Lines 1453 1476 +23
Branches 32 32
===========================================
+ Hits 1453 1476 +23
Continue to review full report at Codecov.
|
pascalgrimaud
requested changes
Dec 12, 2021
| @@ -12,6 +12,7 @@ | |||
| void template(Project project, String source, String sourceFilename, String destination, String destinationFilename); | |||
|
|
|||
| void replaceText(Project project, String source, String sourceFilename, String oldText, String newText); | |||
| void replaceInFile(Project project, String source, String sourceFilename, String regexpText, String newText); | |||
There was a problem hiding this comment.
I would rename this: replaceInFile -> replaceRegexp
It is to not confuse with replaceText
There was a problem hiding this comment.
You're right. I forgot to rename it after my last modification. Fix has been pushed.
|
Thanks a lot @MSaguer for your contribution. And congrats for keeping the coverage at the max :-) I added a minor comment. What do you think? |
pascalgrimaud
approved these changes
Dec 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I propose this PR to close #277
It adds two maven services