-
-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore : Upgrade keycloak to 19.0.0 #2952
Conversation
@@ -2250,5 +2250,63 @@ | |||
}, | |||
"clientPolicies": { | |||
"policies": [] | |||
} | |||
}, | |||
"users": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this merge really mandatory? It's not possible to keep files separated with this version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really don't like this file merge, it is not possible to keep two files here?
Looks like you have a formatting problem. You can run:
(The manual formatting is only needed here since |
2dededa
to
c632619
Compare
You need to update
You then need to update |
Signed-off-by: Pratik Raj <rajpratik71@gmail.com>
c632619
to
6b9fc7a
Compare
Codecov Report
@@ Coverage Diff @@
## main #2952 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 1978 1978
===========================================
Files 470 470
Lines 7995 7990 -5
Branches 155 155
===========================================
- Hits 7995 7990 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Ok, just wasted one hour trying to figure out how to have multiple files for the same realm at startup and that just seems to be a real pain to do (at least the current keycloak codebase don't seems to have something allowing that easily) so this is OK for me. @pascalgrimaud ok for you (as you probably know this part way better than I am), I merge? |
How, just realized that I'm not supposed to merge this since there's a Bounty on it! |
@DamnClin : if it works, you can merge it, no worry about the bounty as once it's submitted, the admins (Julien, Deepu, Daniel and me) will be notified and can approve it |
Yep, that works, thanks a lot @Rajpratik71, don't forget to claim your bounty :) https://www.jhipster.tech/bug-bounties/#how-to-get-the-money |
Sure thanks @DamnClin @pascalgrimaud |
Raised claim at https://opencollective.com/generator-jhipster/expenses/89411 |
Closes #1009
Signed-off-by: Pratik Raj rajpratik71@gmail.com