-
-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial GitLab CI module #2840
Add initial GitLab CI module #2840
Conversation
aab912b
to
7ac3289
Compare
src/main/resources/generator/ci/gitlab/.gitlab-ci-maven.yml.mustache
Outdated
Show resolved
Hide resolved
Looks good to me but @pascalgrimaud is supposed to be on holiday without PC so I can merge it but can't help for the bounty here :) |
Oh, the feature file is missing (to make an actual call to the module WebService). The build will fail for missing coverrage |
7ac3289
to
2125a9d
Compare
No worries, no need to hurry. |
Will have a look. Still need to learn how the ci is working. |
2125a9d
to
257d181
Compare
It will probably be really close to https://github.com/jhipster/jhipster-lite/blob/main/src/test/features/github-actions.feature Those files are run by cucumber (you can start CucumberTest as any JUnit test) and are here to make a full round call (so really calling the exposed WebServices and going through the orchestration). |
Codecov Report
@@ Coverage Diff @@
## main #2840 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 2071 2078 +7
===========================================
Files 479 482 +3
Lines 8198 8215 +17
Branches 164 164
===========================================
+ Hits 8198 8215 +17
Continue to review full report at Codecov.
|
Bounty claimed https://opencollective.com/generator-jhipster/expenses/88237 |
@atomfrede : approved :-) |
A very simple initial gitlab ci configuration. Example run/project can be found here on gitlab.
The build file must not be a mustache template, but I guess it needs to be in future iterations maybe.
closes #423