Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial GitLab CI module #2840

Merged
merged 1 commit into from
Jul 29, 2022

Conversation

atomfrede
Copy link
Member

A very simple initial gitlab ci configuration. Example run/project can be found here on gitlab.

The build file must not be a mustache template, but I guess it needs to be in future iterations maybe.
closes #423

@atomfrede atomfrede force-pushed the 423-add-initial-gitlab-ci-config branch from aab912b to 7ac3289 Compare July 29, 2022 11:28
@DamnClin
Copy link
Collaborator

Looks good to me but @pascalgrimaud is supposed to be on holiday without PC so I can merge it but can't help for the bounty here :)

@DamnClin
Copy link
Collaborator

Oh, the feature file is missing (to make an actual call to the module WebService). The build will fail for missing coverrage

@atomfrede atomfrede force-pushed the 423-add-initial-gitlab-ci-config branch from 7ac3289 to 2125a9d Compare July 29, 2022 11:36
@atomfrede
Copy link
Member Author

Looks good to me but @pascalgrimaud is supposed to be on holiday without PC so I can merge it but can't help for the bounty here :)

No worries, no need to hurry.

@atomfrede
Copy link
Member Author

Oh, the feature file is missing (to make an actual call to the module WebService). The build will fail for missing coverrage

Will have a look. Still need to learn how the ci is working.

@atomfrede atomfrede force-pushed the 423-add-initial-gitlab-ci-config branch from 2125a9d to 257d181 Compare July 29, 2022 11:41
@DamnClin
Copy link
Collaborator

It will probably be really close to https://github.com/jhipster/jhipster-lite/blob/main/src/test/features/github-actions.feature

Those files are run by cucumber (you can start CucumberTest as any JUnit test) and are here to make a full round call (so really calling the exposed WebServices and going through the orchestration).

@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #2840 (257d181) into main (35197e7) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##                main     #2840   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity      2071      2078    +7     
===========================================
  Files            479       482    +3     
  Lines           8198      8215   +17     
  Branches         164       164           
===========================================
+ Hits            8198      8215   +17     
Impacted Files Coverage Δ
...gitlab/application/GitLabCiApplicationService.java 100.00% <100.00%> (ø)
...erator/ci/gitlab/domain/GitLabCiModuleFactory.java 100.00% <100.00%> (ø)
...structure/primary/GitLabCiModuleConfiguration.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35197e7...257d181. Read the comment docs.

@DamnClin DamnClin merged commit f62bde0 into jhipster:main Jul 29, 2022
@atomfrede
Copy link
Member Author

@pascalgrimaud
Copy link
Member

@atomfrede : approved :-)

@pascalgrimaud pascalgrimaud changed the title add initial gitlab ci module Add initial GitLab CI module Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: GitLab CI
3 participants