Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename cypress module #2802

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Conversation

DamnClin
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #2802 (9fa702b) into main (e112595) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##                main     #2802   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      2056      2056           
===========================================
  Files            483       483           
  Lines           8221      8221           
  Branches         166       166           
===========================================
  Hits            8221      8221           
Impacted Files Coverage Δ
...astructure/primary/CypressModuleConfiguration.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e112595...9fa702b. Read the comment docs.

@nonomoho
Copy link
Member

Change in front too?

@DamnClin
Copy link
Collaborator Author

Change in front too?

What do you mean?

@nonomoho
Copy link
Member

You have REACT_CYPRESS = 'REACT_CYPRESS', in Service.ts for instance

@DamnClin
Copy link
Collaborator Author

I think this is useless and should be deleted :)

@DamnClin
Copy link
Collaborator Author

#2803 :)

@pascalgrimaud pascalgrimaud merged commit 8cd7991 into jhipster:main Jul 27, 2022
@DamnClin DamnClin deleted the rename-cypress-module branch July 29, 2022 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants