-
-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sonar documentation #2639
Add sonar documentation #2639
Conversation
src/main/java/tech/jhipster/lite/generator/server/sonar/domain/SonarModulesFactory.java
Show resolved
Hide resolved
@pascalgrimaud test add |
Codecov Report
@@ Coverage Diff @@
## main #2639 +/- ##
===========================================
Coverage 100.00% 100.00%
+ Complexity 2292 2262 -30
===========================================
Files 542 539 -3
Lines 9280 9189 -91
Branches 231 230 -1
===========================================
- Hits 9280 9189 -91
Continue to review full report at Codecov.
|
I think we should add short readmesection for the docker image (I made a test in the mongo DB module) |
ok I'll look it up |
@DamnClin maybe add a specific needle to the docker to start before documentation ? |
I don't know, most of the time I have many docker to start (and I make a makefile but that's not the subject...), I'dd like to have all the command in the frontpage |
I agree with you, I regularly make a script to start everything but if you want to put all the useful commands at launch, they would be better under |
Totally, good idea |
which name would be the most appropriate for this needle ? i can do a MR |
sounds good. I think we should also add a shortcut in JHipsterModule where you give the command and it's doing the other part (formatting, replacement, etc) |
For your information, in generator-jhipster: there are some npm commands to start all docker-compose services. See https://github.com/jhipster/jhipster-sample-app/blob/main/package.json#L32-L38 Some users said me they don't like this, as it looks strange to have these kinds of commands inside
If you think it's a good idea, we can open a ticket for that |
close #2543