Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend maven module #2491

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Frontend maven module #2491

merged 1 commit into from
Jul 11, 2022

Conversation

DamnClin
Copy link
Collaborator

Close #2473

@DamnClin DamnClin force-pushed the frontend-maven-module branch 3 times, most recently from b116f8d to 88ef50f Compare July 10, 2022 19:21
@codecov
Copy link

codecov bot commented Jul 10, 2022 •
edited
Loading

Codecov Report

Merging #2491 (75fe7ee) into main (776eb7f) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##                main     #2491   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
+ Complexity      2428      2425    -3     
===========================================
  Files            548       547    -1     
  Lines           9575      9572    -3     
  Branches         231       231           
===========================================
- Hits            9575      9572    -3
Impacted Files Coverage Δ
...n/application/FrontendMavenApplicationService.java 100.00% <100.00%> (ø)
...ontendmaven/domain/FrontendMavenModuleFactory.java 100.00% <100.00%> (ø)
...ture/primary/FrontendMavenModuleConfiguration.java 100.00% <100.00%> (ø)
...ch/jhipster/lite/module/domain/JHipsterModule.java 100.00% <100.00%> (ø)
...javadependency/JHipsterModuleJavaDependencies.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 776eb7f...75fe7ee. Read the comment docs.

pascalgrimaud
pascalgrimaud requested changes Jul 11, 2022
View reviewed changes
Copy link
Member

@pascalgrimaud pascalgrimaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments

@DamnClin DamnClin force-pushed the frontend-maven-module branch from 88ef50f to 75fe7ee Compare July 11, 2022 06:25
@pascalgrimaud pascalgrimaud enabled auto-merge July 11, 2022 06:30
@pascalgrimaud pascalgrimaud merged commit 3b321fb into jhipster:main Jul 11, 2022
@DamnClin DamnClin deleted the frontend-maven-module branch July 11, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalgrimaud pascalgrimaud pascalgrimaud approved these changes

Assignees
No one assigned
Labels
area: refactoring theme: maven
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate maven frontend
2 participants
@DamnClin @pascalgrimaud