Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate jacoco coverage to module #2469

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Migrate jacoco coverage to module #2469

merged 1 commit into from
Jul 13, 2022

Conversation

DamnClin
Copy link
Collaborator

@DamnClin DamnClin commented Jul 10, 2022 •
edited
Loading

Close #2427

@DamnClin DamnClin marked this pull request as draft July 10, 2022 14:18
@DamnClin DamnClin force-pushed the jacoco-coverrage-module branch from 1af0ae1 to 6790922 Compare July 10, 2022 14:19
@pascalgrimaud pascalgrimaud changed the title Migrate jacoco coverrage to module Migrate jacoco coverage to module Jul 11, 2022
@DamnClin DamnClin force-pushed the jacoco-coverrage-module branch 2 times, most recently from 83657b5 to 145e1bb Compare July 13, 2022 07:21
@DamnClin DamnClin marked this pull request as ready for review July 13, 2022 07:21
@DamnClin DamnClin mentioned this pull request Jul 13, 2022
Closed
@DamnClin DamnClin force-pushed the jacoco-coverrage-module branch from 145e1bb to cad10d4 Compare July 13, 2022 07:26
@codecov
Copy link

codecov bot commented Jul 13, 2022 •
edited
Loading

Codecov Report

Merging #2469 (d30e3af) into main (cd4527e) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##                main     #2469   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity      2320      2329    +9     
===========================================
  Files            539       539           
  Lines           9221      9235   +14     
  Branches         228       229    +1     
===========================================
+ Hits            9221      9235   +14
Impacted Files Coverage Δ
...l/jacoco/application/JacocoApplicationService.java 100.00% <100.00%> (ø)
...ol/jacoco/domain/JacocoThresholdModuleFactory.java 100.00% <100.00%> (ø)
...re/primary/JacocoThresholdModuleConfiguration.java 100.00% <100.00%> (ø)
...ch/jhipster/lite/module/domain/JHipsterModule.java 100.00% <100.00%> (ø)
...e/domain/replacement/RegexNeedleAfterReplacer.java 100.00% <100.00%> (ø)
.../domain/replacement/RegexNeedleBeforeReplacer.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd4527e...d30e3af. Read the comment docs.

@DamnClin DamnClin force-pushed the jacoco-coverrage-module branch 2 times, most recently from 751e45c to ec75431 Compare July 13, 2022 07:57
@DamnClin DamnClin force-pushed the jacoco-coverrage-module branch from ec75431 to d30e3af Compare July 13, 2022 08:08
@pascalgrimaud pascalgrimaud merged commit 987ca3c into jhipster:main Jul 13, 2022
@DamnClin DamnClin deleted the jacoco-coverrage-module branch October 25, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area: refactoring theme: tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate jacoco coverrage to module
2 participants
@DamnClin @pascalgrimaud