Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Kafka domain service to new module system #2455

Merged
merged 24 commits into from
Jul 13, 2022
Merged

Migrate Kafka domain service to new module system #2455

merged 24 commits into from
Jul 13, 2022

Conversation

fdelbrayelle
Copy link
Contributor

@fdelbrayelle fdelbrayelle commented Jul 8, 2022 •
edited
Loading

closes #2109

@fdelbrayelle fdelbrayelle marked this pull request as draft July 8, 2022 15:35
@codecov
Copy link

codecov bot commented Jul 8, 2022 •
edited
Loading

Codecov Report

Merging #2455 (abebdac) into main (fb0d12e) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##                main     #2455   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
+ Complexity      2314      2305    -9     
===========================================
  Files            541       535    -6     
  Lines           9240      9171   -69     
  Branches         221       228    +7     
===========================================
- Hits            9240      9171   -69
Impacted Files Coverage Δ
...ucture/primary/rest/BannerModuleConfiguration.java 100.00% <100.00%> (ø)
...ker/kafka/application/KafkaApplicationService.java 100.00% <100.00%> (ø)
...ngboot/broker/kafka/domain/KafkaModuleFactory.java 100.00% <100.00%> (ø)
...ructure/primary/rest/KafkaModuleConfiguration.java 100.00% <100.00%> (ø)
...vc/security/oauth2/domain/OAuth2ModuleFactory.java 100.00% <100.00%> (ø)
...ch/jhipster/lite/module/domain/JHipsterModule.java 100.00% <0.00%> (ø)
...lite/generator/buildtool/gradle/domain/Gradle.java 100.00% <0.00%> (ø)
...te/generator/project/domain/ProjectRepository.java 100.00% <0.00%> (ø)
...e/module/domain/javadependency/JavaDependency.java 100.00% <0.00%> (ø)
...le/domain/javabuild/command/AddJavaDependency.java 100.00% <0.00%> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb6972b...abebdac. Read the comment docs.

@DamnClin
Copy link
Collaborator

Looks like this module is the lat user of src/main/java/tech/jhipster/lite/generator/readme so I think this package removal should be part of this PR

@DamnClin
Copy link
Collaborator

/!\ breaking change incomming. In #2500 the dependency method become addDependency. I can add some method for migration phase if you want

@fdelbrayelle fdelbrayelle force-pushed the feat/issues/2109_kafka_module branch from a64d850 to c70211c Compare July 11, 2022 13:05
@fdelbrayelle
Copy link
Contributor Author

Looks like this module is the lat user of src/main/java/tech/jhipster/lite/generator/readme so I think this package removal should be part of this PR

Yep I will remove it!

@fdelbrayelle
Copy link
Contributor Author

/!\ breaking change incomming. In #2500 the dependency method become addDependency. I can add some method for migration phase if you want

As you want, I will rebase my branch after main anyway

@fdelbrayelle
Copy link
Contributor Author

/!\ breaking change incomming. In #2500 the dependency method become addDependency. I can add some method for migration phase if you want

Fixed here: c9da3d2

@fdelbrayelle fdelbrayelle force-pushed the feat/issues/2109_kafka_module branch 4 times, most recently from b427523 to 4cb46e8 Compare July 11, 2022 13:41
@fdelbrayelle
Copy link
Contributor Author

Looks like this module is the lat user of src/main/java/tech/jhipster/lite/generator/readme so I think this package removal should be part of this PR

Now removed!

@fdelbrayelle fdelbrayelle force-pushed the feat/issues/2109_kafka_module branch from d8dc910 to 15b8e5c Compare July 11, 2022 14:40
@fdelbrayelle fdelbrayelle marked this pull request as ready for review July 11, 2022 16:47
@fdelbrayelle fdelbrayelle changed the title Feat/issues/2109 kafka module Kafka module migration Jul 12, 2022
@fdelbrayelle fdelbrayelle changed the title Kafka module migration Migrate Kafka domain service to new module system Jul 12, 2022
@fdelbrayelle fdelbrayelle force-pushed the feat/issues/2109_kafka_module branch from 444c094 to 6605fea Compare July 12, 2022 12:54
@fdelbrayelle fdelbrayelle force-pushed the feat/issues/2109_kafka_module branch from 6605fea to 43662e1 Compare July 12, 2022 13:07
@pascalgrimaud pascalgrimaud merged commit 72cd3d4 into jhipster:main Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DamnClin DamnClin DamnClin left review comments

@pascalgrimaud pascalgrimaud pascalgrimaud approved these changes

Assignees
No one assigned
Labels
area: refactoring server: spring boot theme: broker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert kafka to module
3 participants
@fdelbrayelle @DamnClin @pascalgrimaud