Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: rename error to base #244

Merged
merged 1 commit into from
Nov 27, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ JHipster Light will help you to start your project:

- init the project
- add Maven as Build Tool
- add Base classes and Domain Error
- add Spring Boot as Server Framework
- add Tomcat or Undertow as Server
- add PostgreSQL as Database
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
package tech.jhipster.light.generator.server.javatool.base.application;

import org.springframework.stereotype.Service;
import tech.jhipster.light.generator.project.domain.Project;
import tech.jhipster.light.generator.server.javatool.base.domain.JavaBaseService;

@Service
public class JavaBaseApplicationService {

private final JavaBaseService javaBaseService;

public JavaBaseApplicationService(JavaBaseService javaBaseService) {
this.javaBaseService = javaBaseService;
}

public void init(Project project) {
javaBaseService.init(project);
}
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package tech.jhipster.light.generator.server.javatool.error.domain;
package tech.jhipster.light.generator.server.javatool.base.domain;

import static tech.jhipster.light.common.domain.FileUtils.getPath;
import static tech.jhipster.light.generator.project.domain.Constants.MAIN_JAVA;
Expand All @@ -8,13 +8,13 @@
import tech.jhipster.light.generator.project.domain.Project;
import tech.jhipster.light.generator.project.domain.ProjectRepository;

public class ErrorDomainService implements ErrorService {
public class JavaBaseDomainService implements JavaBaseService {

public static final String SOURCE = "server/javatool/error";
public static final String SOURCE = "server/javatool/base";

private final ProjectRepository projectRepository;

public ErrorDomainService(ProjectRepository projectRepository) {
public JavaBaseDomainService(ProjectRepository projectRepository) {
this.projectRepository = projectRepository;
}

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
package tech.jhipster.light.generator.server.javatool.base.domain;

import tech.jhipster.light.generator.project.domain.Project;

public interface JavaBaseService {
void init(Project project);
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
package tech.jhipster.light.generator.server.javatool.base.infrastructure.beans;

import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
import tech.jhipster.light.generator.project.domain.ProjectRepository;
import tech.jhipster.light.generator.server.javatool.base.domain.JavaBaseDomainService;
import tech.jhipster.light.generator.server.javatool.base.domain.JavaBaseService;

@Configuration
public class JavaBaseBeanConfiguration {

private final ProjectRepository projectRepository;

public JavaBaseBeanConfiguration(ProjectRepository projectRepository) {
this.projectRepository = projectRepository;
}

@Bean
public JavaBaseService javaBaseService() {
return new JavaBaseDomainService(projectRepository);
}
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package tech.jhipster.light.generator.server.javatool.error.infrastructure.primary.rest;
package tech.jhipster.light.generator.server.javatool.base.infrastructure.primary.rest;

import io.swagger.v3.oas.annotations.Operation;
import io.swagger.v3.oas.annotations.responses.ApiResponse;
Expand All @@ -10,24 +10,24 @@
import org.springframework.web.bind.annotation.RestController;
import tech.jhipster.light.generator.project.domain.Project;
import tech.jhipster.light.generator.project.infrastructure.primary.dto.ProjectDTO;
import tech.jhipster.light.generator.server.javatool.error.application.ErrorApplicationService;
import tech.jhipster.light.generator.server.javatool.base.application.JavaBaseApplicationService;

@RestController
@RequestMapping("/api/servers/java/error")
@RequestMapping("/api/servers/java/base")
@Tag(name = "Java")
class ErrorResource {
class JavaBaseResource {

private final ErrorApplicationService errorApplicationService;
private final JavaBaseApplicationService javaBaseApplicationService;

public ErrorResource(ErrorApplicationService errorApplicationService) {
this.errorApplicationService = errorApplicationService;
public JavaBaseResource(JavaBaseApplicationService javaBaseApplicationService) {
this.javaBaseApplicationService = javaBaseApplicationService;
}

@Operation(summary = "Add Error domain to project")
@Operation(summary = "Add Base classes and Error domain to project")
@ApiResponses({ @ApiResponse(responseCode = "500", description = "An error occurred while initializing project") })
@PostMapping
public void init(@RequestBody ProjectDTO projectDTO) {
Project project = ProjectDTO.toProject(projectDTO);
errorApplicationService.init(project);
javaBaseApplicationService.init(project);
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
@tech.jhipster.light.BusinessContext
package tech.jhipster.light.generator.server.javatool.base;

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package tech.jhipster.light.generator.server.javatool.error.application;
package tech.jhipster.light.generator.server.javatool.base.application;

import static tech.jhipster.light.TestUtils.*;
import static tech.jhipster.light.common.domain.FileUtils.getPath;
Expand All @@ -10,16 +10,16 @@
import tech.jhipster.light.generator.project.domain.Project;

@IntegrationTest
class ErrorApplicationServiceIT {
class JavaBaseApplicationServiceIT {

@Autowired
ErrorApplicationService errorApplicationService;
JavaBaseApplicationService javaBaseApplicationService;

@Test
void shouldInit() {
Project project = tmpProject();

errorApplicationService.init(project);
javaBaseApplicationService.init(project);

String pathMain = "src/main/java/com/mycompany/myapp/error/domain";
assertFileExist(project, getPath(pathMain, "Assert.java"));
Expand All @@ -40,7 +40,7 @@ void shouldInitWithSpecificPackage() {
Project project = tmpProject();
project.addConfig(PACKAGE_NAME, "tech.jhipster.chips");

errorApplicationService.init(project);
javaBaseApplicationService.init(project);

String packageResult = "package tech.jhipster.chips.error.domain;";

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package tech.jhipster.light.generator.server.javatool.error.domain;
package tech.jhipster.light.generator.server.javatool.base.domain;

import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.anyString;
Expand All @@ -17,19 +17,19 @@

@UnitTest
@ExtendWith(MockitoExtension.class)
class ErrorDomainServiceTest {
class JavaBaseDomainServiceTest {

@Mock
ProjectRepository projectRepository;

@InjectMocks
ErrorDomainService errorDomainService;
JavaBaseDomainService javaBaseDomainService;

@Test
void shouldInit() {
Project project = tmpProject();

errorDomainService.init(project);
javaBaseDomainService.init(project);

verify(projectRepository, times(8)).template(any(Project.class), anyString(), anyString(), anyString());
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,21 +1,21 @@
package tech.jhipster.light.generator.server.javatool.error.infrastructure.beans;
package tech.jhipster.light.generator.server.javatool.base.infrastructure.beans;

import static org.assertj.core.api.Assertions.*;

import org.junit.jupiter.api.Test;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.context.ApplicationContext;
import tech.jhipster.light.IntegrationTest;
import tech.jhipster.light.generator.server.javatool.error.domain.ErrorDomainService;
import tech.jhipster.light.generator.server.javatool.base.domain.JavaBaseDomainService;

@IntegrationTest
class ErrorServiceBeanConfigurationIT {
class JavaBaseBeanConfigurationIT {

@Autowired
ApplicationContext applicationContext;

@Test
void shouldGetBean() {
assertThat(applicationContext.getBean("errorService")).isNotNull().isInstanceOf(ErrorDomainService.class);
assertThat(applicationContext.getBean("javaBaseService")).isNotNull().isInstanceOf(JavaBaseDomainService.class);
}
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package tech.jhipster.light.generator.server.javatool.error.infrastructure.primary.rest;
package tech.jhipster.light.generator.server.javatool.base.infrastructure.primary.rest;

import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.post;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;
Expand All @@ -20,7 +20,7 @@

@IntegrationTest
@AutoConfigureMockMvc
class ErrorResourceIT {
class JavaBaseResourceIT {

@Autowired
MockMvc mockMvc;
Expand All @@ -35,7 +35,7 @@ void shouldInit() throws Exception {

mockMvc
.perform(
post("/api/servers/java/error").contentType(MediaType.APPLICATION_JSON).content(TestUtils.convertObjectToJsonBytes(projectDTO))
post("/api/servers/java/base").contentType(MediaType.APPLICATION_JSON).content(TestUtils.convertObjectToJsonBytes(projectDTO))
)
.andExpect(status().isOk());

Expand Down
2 changes: 1 addition & 1 deletion tests/generate.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ callApi() {

callApi beer.json "/api/projects/init"
callApi beer.json "/api/build-tools/maven"
callApi beer.json "/api/servers/java/error"
callApi beer.json "/api/servers/java/base"
callApi beer.json "/api/servers/spring-boot"
callApi beer.json "/api/servers/spring-boot/banner/jhipster-v7"
callApi beer.json "/api/servers/spring-boot/web/tomcat"
Expand Down