Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JPA reset option for cucumber #2211

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

DamnClin
Copy link
Collaborator

Close #2210

@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #2211 (fe9b99d) into main (16d451d) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##                main     #2211   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity      2486      2490    +4     
===========================================
  Files            539       539           
  Lines           9273      9288   +15     
  Branches         210       211    +1     
===========================================
+ Hits            9273      9288   +15     
Impacted Files Coverage Δ
...ingboot/cucumber/domain/CucumberModuleFactory.java 100.00% <100.00%> (ø)
...structure/primary/CucumberModuleConfiguration.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d5c0fc...fe9b99d. Read the comment docs.

@DamnClin
Copy link
Collaborator Author

To be honest I think this should be a dedicated module in the future BUT I need a boolean option in a module to advance on integration and this is the first one that came to my mind...

@pascalgrimaud
Copy link
Member

pascalgrimaud commented Jun 23, 2022

It looks good. Anyway, it can't work for NoSQL database
How could we manage this?

Just woke up, forget my comment, the needJpa property do the job ;p

@pascalgrimaud pascalgrimaud merged commit ad45924 into jhipster:main Jun 23, 2022
@DamnClin DamnClin deleted the jpa-reset-option branch June 25, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to wipe data in cucumber module
2 participants