Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devtools to new module system #2150

Merged
merged 1 commit into from
Jun 19, 2022

Conversation

antarus
Copy link
Contributor

@antarus antarus commented Jun 18, 2022

close #2114

@codecov
Copy link

codecov bot commented Jun 18, 2022

Codecov Report

Merging #2150 (bd40346) into main (8acdc6a) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##                main     #2150   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
+ Complexity      2407      2401    -6     
===========================================
  Files            517       516    -1     
  Lines           8899      8895    -4     
  Branches         203       203           
===========================================
- Hits            8899      8895    -4     
Impacted Files Coverage Δ
...vtools/application/DevToolsApplicationService.java 100.00% <100.00%> (ø)
...ingboot/devtools/domain/DevToolsModuleFactory.java 100.00% <100.00%> (ø)
...structure/primary/DevToolsModuleConfiguration.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8acdc6a...bd40346. Read the comment docs.

@DamnClin
Copy link
Collaborator

Looks good to me!

@pascalgrimaud pascalgrimaud marked this pull request as ready for review June 19, 2022 05:33
@pascalgrimaud pascalgrimaud merged commit c9c28e9 into jhipster:main Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert Dev tools to module
3 participants