Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front part to generate Angular Health #2120

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

qmonmert
Copy link
Contributor

Related to #1652

@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #2120 (d280156) into main (daf5225) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##                main     #2120   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      2430      2430           
===========================================
  Files            520       520           
  Lines           8916      8923    +7     
  Branches         199       200    +1     
===========================================
+ Hits            8916      8923    +7     
Impacted Files Coverage Δ
.../springboot/primary/generator/ServiceProjection.ts 100.00% <ø> (ø)
src/main/webapp/app/common/domain/Service.ts 100.00% <100.00%> (ø)
...or/angular-generator/AngularGenerator.component.ts 100.00% <100.00%> (ø)
...p/springboot/secondary/client/AngularRepository.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daf5225...d280156. Read the comment docs.

@qmonmert qmonmert requested a review from pascalgrimaud June 15, 2022 18:12
Copy link
Member

@pascalgrimaud pascalgrimaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • missing cypress tests
  • missing projection to handle the button when it is already used at least 1 time

@pascalgrimaud pascalgrimaud merged commit 18edadf into jhipster:main Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants