Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple modules screen #2055

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Simple modules screen #2055

merged 1 commit into from
Jun 14, 2022

Conversation

DamnClin
Copy link
Collaborator

@DamnClin DamnClin commented Jun 13, 2022

A simple component to list module. The goal is to use this to apply module depending on there properties but I still don't know what the UX should be on this part.

Related to #2055 (comment)

@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #2055 (57bcb28) into main (7384c6f) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##                main     #2055   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      2417      2417           
===========================================
  Files            501       505    +4     
  Lines           8659      8690   +31     
  Branches         188       189    +1     
===========================================
+ Hits            8659      8690   +31     
Impacted Files Coverage Δ
src/main/webapp/app/loader/primary/Loader.ts 100.00% <100.00%> (ø)
...dule/primary/modules-list/ModulesList.component.ts 100.00% <100.00%> (ø)
...in/webapp/app/module/primary/modules-list/index.ts 100.00% <100.00%> (ø)
...bapp/app/module/secondary/RestModulesRepository.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 684e8df...57bcb28. Read the comment docs.

@pascalgrimaud
Copy link
Member

Will give a try soon :)

@pascalgrimaud pascalgrimaud merged commit f6519c5 into jhipster:main Jun 14, 2022
@DamnClin DamnClin deleted the modules-list branch October 25, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants