Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cucumber module #1875

Merged
merged 1 commit into from
May 29, 2022
Merged

Cucumber module #1875

merged 1 commit into from
May 29, 2022

Conversation

DamnClin
Copy link
Collaborator

@DamnClin DamnClin commented May 28, 2022

Module to add cucumber to a project

Close #1699

@DamnClin DamnClin marked this pull request as draft May 28, 2022 14:01
@DamnClin
Copy link
Collaborator Author

@pascalgrimaud where do you think the project generation test should be added for this one?

@DamnClin
Copy link
Collaborator Author

BTW this needs #1874 :D

@pascalgrimaud
Copy link
Member

@pascalgrimaud where do you think the project generation test should be added for this one?

Don't understand well the question. Shouldn't we keep the same structure of folder than in JH Lite ?

@DamnClin
Copy link
Collaborator Author

@pascalgrimaud where do you think the project generation test should be added for this one?

Don't understand well the question. Shouldn't we keep the same structure of folder than in JH Lite ?

No, I mean I added it in fullapp, is this correct?

@pascalgrimaud
Copy link
Member

@DamnClin : oh yes, looks good to add this to fullapp

@DamnClin DamnClin marked this pull request as ready for review May 28, 2022 15:37
@DamnClin DamnClin force-pushed the cucumber-module branch 3 times, most recently from 2c0e1d7 to bd869c6 Compare May 28, 2022 16:14
@codecov
Copy link

codecov bot commented May 28, 2022

Codecov Report

Merging #1875 (2b2f443) into main (2f44c56) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                main     #1875    +/-   ##
============================================
  Coverage     100.00%   100.00%            
- Complexity      2112      2137    +25     
============================================
  Files            442       446     +4     
  Lines           7680      7812   +132     
  Branches         170       171     +1     
============================================
+ Hits            7680      7812   +132     
Impacted Files Coverage Δ
.../infrastructure/secondary/MavenCommandHandler.java 100.00% <100.00%> (ø)
...cumber/application/CucumberApplicationService.java 100.00% <100.00%> (ø)
...ingboot/cucumber/domain/CucumberModuleFactory.java 100.00% <100.00%> (ø)
...boot/cucumber/domain/CucumberModuleProperties.java 100.00% <100.00%> (ø)
...umber/infrastructure/primary/CucumberResource.java 100.00% <100.00%> (ø)
...hipster/lite/generator/module/JHipsterModules.java 100.00% <0.00%> (ø)
...t/banner/application/BannerApplicationService.java 100.00% <0.00%> (ø)
...er/infrastructure/primary/rest/BannerResource.java 100.00% <0.00%> (ø)
.../springboot/banner/domain/BannerDomainService.java
...infrastructure/config/BannerBeanConfiguration.java
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f44c56...2b2f443. Read the comment docs.

Module to add cucumber to a project
@pascalgrimaud pascalgrimaud merged commit 48eab65 into jhipster:main May 29, 2022
@DamnClin DamnClin deleted the cucumber-module branch May 30, 2022 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Cucumber
2 participants