Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init: use cucumber for tests #1841

Merged
merged 1 commit into from
May 25, 2022

Conversation

pascalgrimaud
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #1841 (b99dd38) into main (3077a40) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##                main     #1841   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      1849      1849           
===========================================
  Files            395       395           
  Lines           6964      6964           
  Branches         155       155           
===========================================
  Hits            6964      6964           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3077a40...b99dd38. Read the comment docs.

@DamnClin
Copy link
Collaborator

What do you think, the usage is easy enough? In this case you can delete your Rest controller IT and your domain UnitTest I think, you'll get the same coverage but more value since it's actually testing stuff

@pascalgrimaud
Copy link
Member Author

I already deleted the InitResourceIT

About the Unit test in Domain and Application Service, I'm working on another PR to use the new system with modules, so I'll delete these files in another PR. Then, we'll have a clean "init" context :-)

@DamnClin
Copy link
Collaborator

Careful you don't need #1787 to make this happen (the work on this is at step 0 :D: I have a ticket)

@pascalgrimaud
Copy link
Member Author

ahaha yes, that's why I choose a context which doesn't need Java dependencies :)

@pascalgrimaud pascalgrimaud merged commit f794b0f into jhipster:main May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants