Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Logger to Vue common application #1818

Merged
merged 3 commits into from
May 24, 2022
Merged

Add Logger to Vue common application #1818

merged 3 commits into from
May 24, 2022

Conversation

matthieuRioual
Copy link
Contributor

Add Logger to vue Default application

@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #1818 (961c5c0) into main (06e2388) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##                main     #1818   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity      1819      1848   +29     
===========================================
  Files            391       394    +3     
  Lines           6864      6950   +86     
  Branches         152       154    +2     
===========================================
+ Hits            6864      6950   +86     
Impacted Files Coverage Δ
...rator/client/vue/core/domain/VueDomainService.java 100.00% <100.00%> (ø)
...hipster/lite/generator/project/domain/Project.java 100.00% <0.00%> (ø)
...r/lite/generator/module/domain/JHipsterModule.java 100.00% <0.00%> (ø)
...r/lite/generator/module/domain/JHipsterSource.java 100.00% <0.00%> (ø)
...r/lite/generator/project/domain/DefaultConfig.java 100.00% <0.00%> (ø)
...e/generator/module/domain/JHipsterDestination.java 100.00% <0.00%> (ø)
...e/generator/module/domain/JHipsterFileContent.java 100.00% <0.00%> (ø)
...generator/module/domain/JHipsterModuleContext.java 100.00% <0.00%> (ø)
...generator/module/domain/JHipsterProjectFolder.java 100.00% <0.00%> (ø)
...project/infrastructure/primary/dto/ProjectDTO.java 100.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d0b413...961c5c0. Read the comment docs.

@pascalgrimaud
Copy link
Member

@matthieuRioual : looks good, but can you improve VueApplicationServiceIT and VueAssert too plz? So we are sure the files are correctly generated

@matthieuRioual
Copy link
Contributor Author

matthieuRioual commented May 24, 2022

@matthieuRioual : looks good, but can you improve VueApplicationServiceIT and VueAssert too plz? So we are sure the files are correctly generated

Between, i will add assertAxiosFiles method which is implemented but not called in ApplicationService

@pascalgrimaud pascalgrimaud merged commit 9cadd15 into jhipster:main May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants