Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MSSQL core #1770

Merged
merged 3 commits into from
Jun 15, 2022
Merged

Add MSSQL core #1770

merged 3 commits into from
Jun 15, 2022

Conversation

seraphinandrieux
Copy link
Contributor

@seraphinandrieux seraphinandrieux commented May 18, 2022 •
edited
Loading

@seraphinandrieux seraphinandrieux marked this pull request as draft May 18, 2022 09:27
@seraphinandrieux seraphinandrieux force-pushed the 428-add-mssql branch 3 times, most recently from 5bc901f to 43b1e26 Compare May 18, 2022 15:15
@seraphinandrieux seraphinandrieux marked this pull request as ready for review May 18, 2022 15:27
@seraphinandrieux seraphinandrieux force-pushed the 428-add-mssql branch 5 times, most recently from 8c66289 to afc7d65 Compare May 18, 2022 16:23
@codecov
Copy link

codecov bot commented May 18, 2022 •
edited
Loading

Codecov Report

Merging #1770 (1873610) into main (5b48d4c) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                main     #1770    +/-   ##
============================================
  Coverage     100.00%   100.00%            
- Complexity      2390      2419    +29     
============================================
  Files            507       515     +8     
  Lines           8730      8863   +133     
  Branches         196       199     +3     
============================================
+ Hits            8730      8863   +133
Impacted Files Coverage Δ
...er/lite/generator/project/domain/DatabaseType.java 100.00% <100.00%> (ø)
...ase/mssql/application/MssqlApplicationService.java 100.00% <100.00%> (ø)
...server/springboot/database/mssql/domain/Mssql.java 100.00% <100.00%> (ø)
...boot/database/mssql/domain/MssqlDomainService.java 100.00% <100.00%> (ø)
.../infrastructure/config/MssqlBeanConfiguration.java 100.00% <100.00%> (ø)
...sql/infrastructure/primary/rest/MssqlResource.java 100.00% <100.00%> (ø)
src/main/webapp/app/common/domain/Service.ts 100.00% <0.00%> (ø)
.../main/webapp/app/common/secondary/RestServiceId.ts 100.00% <0.00%> (ø)
...p/app/springboot/secondary/SpringBootRepository.ts 100.00% <0.00%> (ø)
.../springboot/primary/generator/ServiceProjection.ts 100.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b48d4c...1873610. Read the comment docs.

@seraphinandrieux seraphinandrieux marked this pull request as draft May 18, 2022 16:48
@seraphinandrieux seraphinandrieux force-pushed the 428-add-mssql branch 4 times, most recently from ee4f64d to 5931c0f Compare May 27, 2022 05:40
@seraphinandrieux seraphinandrieux marked this pull request as ready for review May 27, 2022 05:53
pascalgrimaud
pascalgrimaud requested changes May 27, 2022
View reviewed changes
src/test/java/tech/jhipster/lite/generator/docker/application/DockerApplicationServiceIT.java Outdated
@@ -28,6 +28,6 @@ void shouldGetImageVersion() {
Optional<String> imageVersion = dockerApplicationService.getImageVersion("mysql");

// Then
assertThat(imageVersion).contains("8.0.28");
assertThat(imageVersion).contains("8.0.29");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment about hard coded version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't for this one remove it, the method tests which version is used

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ok, then let's keep like this so, and improve it in another PR

@seraphinandrieux seraphinandrieux force-pushed the 428-add-mssql branch 2 times, most recently from 14dbd70 to 68438ac Compare May 27, 2022 14:50
pascalgrimaud
pascalgrimaud previously approved these changes May 28, 2022
View reviewed changes
@pascalgrimaud
Copy link
Member

Something wrong in the CI, as it took a lot of time
I need to investigate

@seraphinandrieux seraphinandrieux force-pushed the 428-add-mssql branch 2 times, most recently from 346b228 to 4dcff37 Compare May 31, 2022 05:52
@seraphinandrieux seraphinandrieux marked this pull request as draft May 31, 2022 06:08
@seraphinandrieux
Copy link
Contributor Author

Error from logs :
Caused by: com.microsoft.sqlserver.jdbc.SQLServerException: The driver could not establish a secure connection to SQL Server by using Secure Sockets Layer (SSL) encryption. Error: "PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target".

@seraphinandrieux seraphinandrieux force-pushed the 428-add-mssql branch 6 times, most recently from 06d84dd to 2a82bb9 Compare June 7, 2022 05:35
@seraphinandrieux seraphinandrieux force-pushed the 428-add-mssql branch 4 times, most recently from e83bdfd to f4398dc Compare June 15, 2022 08:52
@seraphinandrieux seraphinandrieux marked this pull request as ready for review June 15, 2022 09:04
@seraphinandrieux seraphinandrieux force-pushed the 428-add-mssql branch 2 times, most recently from e2eda43 to 866d1ca Compare June 15, 2022 13:48
@pascalgrimaud pascalgrimaud merged commit ec45869 into jhipster:main Jun 15, 2022
@seraphinandrieux
Copy link
Contributor Author

$300 bounty claimed: https://opencollective.com/generator-jhipster/expenses/82466

@pascalgrimaud
Copy link
Member

@seraphinandrieux : approved, thanks so much for your work here. Perfect time, I needs this ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalgrimaud pascalgrimaud pascalgrimaud approved these changes

Assignees
No one assigned
Labels
area: feature request 💡 server: spring boot theme: database
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seraphinandrieux @pascalgrimaud