Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add oauth 2 Angular #1701

Merged
merged 18 commits into from
May 18, 2022
Merged

Add oauth 2 Angular #1701

merged 18 commits into from
May 18, 2022

Conversation

Bolo89
Copy link
Contributor

@Bolo89 Bolo89 commented May 11, 2022 •
edited
Loading

@codecov
Copy link

codecov bot commented May 11, 2022 •
edited
Loading

Codecov Report

Merging #1701 (8ed3d2c) into main (1b9708c) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                main     #1701    +/-   ##
============================================
  Coverage     100.00%   100.00%            
- Complexity      1701      1774    +73     
============================================
  Files            370       379     +9     
  Lines           6501      6736   +235     
  Branches         148       154     +6     
============================================
+ Hits            6501      6736   +235
Impacted Files Coverage Δ
...va/tech/jhipster/lite/common/domain/WordUtils.java 100.00% <ø> (ø)
.../main/webapp/app/common/secondary/RestServiceId.ts 100.00% <ø> (ø)
.../springboot/primary/generator/ServiceProjection.ts 100.00% <ø> (ø)
...n/application/AngularCommonApplicationService.java 100.00% <100.00%> (ø)
...or/client/angular/common/domain/AngularCommon.java 100.00% <100.00%> (ø)
...ular/common/domain/AngularCommonDomainService.java 100.00% <100.00%> (ø)
...infrastructure/AngularCommonBeanConfiguration.java 100.00% <100.00%> (ø)
...2/application/AngularOauth2ApplicationService.java 100.00% <100.00%> (ø)
.../angular/security/oauth2/domain/AngularOauth2.java 100.00% <100.00%> (ø)
...rity/oauth2/domain/AngularOauth2DomainService.java 100.00% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b9708c...8ed3d2c. Read the comment docs.

@Bolo89 Bolo89 force-pushed the add-angular-common-service branch from 36fb703 to 80ad802 Compare May 13, 2022 17:43
@Bolo89 Bolo89 changed the title Add angular common service Add oauth 2 Angular May 15, 2022
@Bolo89 Bolo89 requested review from pascalgrimaud and qmonmert May 15, 2022 16:26
@pascalgrimaud
Copy link
Member

Can you update this PR, using the new https://github.com/jhipster/jhipster-lite/blob/main/src/main/java/tech/jhipster/lite/generator/project/domain/ProjectFile.java plz?

@Bolo89 Bolo89 force-pushed the add-angular-common-service branch from d891c24 to d515cec Compare May 16, 2022 07:30
pascalgrimaud
pascalgrimaud previously approved these changes May 18, 2022
View reviewed changes
Bolo89 and others added 5 commits May 18, 2022 14:34
@Bolo89 @pascalgrimaud
Update src/main/java/tech/jhipster/lite/generator/client/angular/secu…
0cb1222 
…rity/oauth2/infrastructure/primary/AngularOauth2Resource.java

Co-authored-by: Pascal Grimaud <pascalgrimaud@gmail.com>
@Bolo89 @pascalgrimaud
Update src/main/java/tech/jhipster/lite/generator/client/angular/secu…
3fefe0b 
…rity/oauth2/infrastructure/primary/AngularOauth2Resource.java

Co-authored-by: Pascal Grimaud <pascalgrimaud@gmail.com>
@Bolo89 @pascalgrimaud
Update src/main/webapp/app/springboot/primary/generator/angular-gener…
caf5c6b 
…ator/AngularGenerator.vue

Co-authored-by: Pascal Grimaud <pascalgrimaud@gmail.com>
@Bolo89 @pascalgrimaud
Update src/test/javascript/cypress/integration/Generator.spec.ts
647e752 
Co-authored-by: Pascal Grimaud <pascalgrimaud@gmail.com>
@Bolo89
Angular oauth2 / clean code
d89dda9
@Bolo89 Bolo89 force-pushed the add-angular-common-service branch from fecc241 to d89dda9 Compare May 18, 2022 12:37
@pascalgrimaud pascalgrimaud added $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $300 https://www.jhipster.tech/bug-bounties/ and removed $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $300 https://www.jhipster.tech/bug-bounties/ labels May 18, 2022
@pascalgrimaud
Copy link
Member

move the bounty to the ticket, not to this PR :D

@pascalgrimaud pascalgrimaud merged commit 6706f44 into jhipster:main May 18, 2022
@pascalgrimaud
Copy link
Member

thanks a lot for your work @Bolo89
it's awesome!

@Bolo89 Bolo89 deleted the add-angular-common-service branch May 20, 2022 07:44
@Bolo89
Copy link
Contributor Author

Bolo89 commented Jul 2, 2022

Bounty claimed at https://opencollective.com/generator-jhipster/expenses/84925

@pascalgrimaud
Copy link
Member

@Bolo89 : approved, thanks for your work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmonmert qmonmert qmonmert left review comments

@pascalgrimaud pascalgrimaud pascalgrimaud approved these changes

Assignees
No one assigned
Labels
area: feature request 💡 client: angular theme: security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Angular: add OAuth2 keycloak authentication
3 participants
@Bolo89 @pascalgrimaud @qmonmert