Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BigDecimal asserter #1667

Merged
merged 1 commit into from
May 10, 2022
Merged

Conversation

DamnClin
Copy link
Collaborator

@DamnClin DamnClin commented May 9, 2022

Added Assertions for BigDecimal

@CLAassistant
Copy link

CLAassistant commented May 9, 2022

CLA assistant check
All committers have signed the CLA.

@pascalgrimaud
Copy link
Member

congrats @DamnClin ! you managed to sign the CLA :trollface:

@DamnClin
Copy link
Collaborator Author

DamnClin commented May 9, 2022

congrats @DamnClin ! you managed to sign the CLA :trollface:

That was actually harder than doing this implementation...

@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #1667 (67d11ea) into main (6b535a1) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##                main     #1667   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity      1655      1661    +6     
===========================================
  Files            355       355           
  Lines           5836      5887   +51     
  Branches         141       145    +4     
===========================================
+ Hits            5836      5887   +51     
Impacted Files Coverage Δ
.../lite/error/domain/NumberValueTooLowException.java 100.00% <ø> (ø)
...n/java/tech/jhipster/lite/error/domain/Assert.java 100.00% <100.00%> (ø)
...lite/error/domain/NumberValueTooHighException.java 100.00% <100.00%> (ø)
...ter/lite/generator/client/vue/core/domain/Vue.java 100.00% <0.00%> (ø)
...rator/client/vue/core/domain/VueDomainService.java 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b535a1...67d11ea. Read the comment docs.

@DamnClin DamnClin force-pushed the big-decimal-asserter branch from 7551c5e to 67d11ea Compare May 9, 2022 13:07
@pascalgrimaud pascalgrimaud merged commit 7d2a55c into jhipster:main May 10, 2022
@DamnClin DamnClin deleted the big-decimal-asserter branch May 28, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants