Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: refactoring to have a login component #1661

Merged
merged 1 commit into from
May 12, 2022

Conversation

qmonmert
Copy link
Contributor

@qmonmert qmonmert commented May 8, 2022

Fix #1660

@qmonmert qmonmert force-pushed the feature/1660 branch 2 times, most recently from aeb20c1 to 017f366 Compare May 8, 2022 18:25
@codecov
Copy link

codecov bot commented May 8, 2022

Codecov Report

Merging #1661 (6f90661) into main (32ab0a5) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##                main     #1661   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
+ Complexity      1655      1649    -6     
===========================================
  Files            355       356    +1     
  Lines           5836      5881   +45     
  Branches         141       141           
===========================================
+ Hits            5836      5881   +45     
Impacted Files Coverage Δ
.../generator/client/angular/core/domain/Angular.java 100.00% <100.00%> (ø)
...client/angular/security/jwt/domain/AngularJwt.java 100.00% <100.00%> (ø)
...r/security/jwt/domain/AngularJwtDomainService.java 100.00% <100.00%> (ø)
...n/java/tech/jhipster/lite/error/domain/Assert.java 100.00% <0.00%> (ø)
...ter/lite/generator/client/vue/core/domain/Vue.java 100.00% <0.00%> (ø)
...enerator/server/javatool/arch/domain/ArchUnit.java 100.00% <0.00%> (ø)
...enerator/server/javatool/base/domain/JavaBase.java 100.00% <0.00%> (ø)
...rator/client/vue/core/domain/VueDomainService.java 100.00% <0.00%> (ø)
...ator/svelte-generator/SvelteGenerator.component.ts 100.00% <0.00%> (ø)
...pp/springboot/secondary/client/SvelteRepository.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32ab0a5...6f90661. Read the comment docs.

@qmonmert
Copy link
Contributor Author

qmonmert commented May 8, 2022

TODO: fix
image

@qmonmert qmonmert requested a review from pascalgrimaud May 11, 2022 19:23
@pascalgrimaud pascalgrimaud merged commit bcd8b2a into jhipster:main May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular: refactoring to have a login component
2 participants