Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Collection asserters #1616

Merged
merged 1 commit into from
May 6, 2022
Merged

Conversation

sophie-stan
Copy link
Contributor

@sophie-stan sophie-stan commented May 6, 2022

@CLAassistant
Copy link

CLAassistant commented May 6, 2022

CLA assistant check
All committers have signed the CLA.

@pascalgrimaud
Copy link
Member

@sstan001 : first of all, big thanks for your 1st contribution and welcome on board :-)

Some minor comments:

  • plz add in description fix https://github.com/jhipster/jhipster-lite/issues/1606 so this ticket will be auto closed once this pull request is merged
  • then, you need to sign the CLA, it means you give your code to the JHipster project

@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #1616 (19b90c9) into main (c5196ea) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##                main     #1616   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity      1642      1646    +4     
===========================================
  Files            348       350    +2     
  Lines           5770      5814   +44     
  Branches         137       141    +4     
===========================================
+ Hits            5770      5814   +44     
Impacted Files Coverage Δ
...n/java/tech/jhipster/lite/error/domain/Assert.java 100.00% <100.00%> (ø)
...error/domain/NullElementInCollectionException.java 100.00% <100.00%> (ø)
...er/lite/error/domain/TooManyElementsException.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61d64c5...19b90c9. Read the comment docs.

@pascalgrimaud
Copy link
Member

pascalgrimaud commented May 6, 2022

Thanks and congrats for your 1st contribution @sstan001
Just FYI, I edited your initial description to not close automatically the ticket, because there is still the template part to do, before closing it

@pascalgrimaud pascalgrimaud merged commit 0805407 into jhipster:main May 6, 2022
@sophie-stan sophie-stan deleted the addAsserters branch May 9, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants