Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming convention for APIs #1289

Merged
merged 2 commits into from
Apr 8, 2022
Merged

Conversation

hdurix
Copy link
Member

@hdurix hdurix commented Apr 8, 2022

@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #1289 (e6822d6) into main (42d8a8d) will not change coverage.
The diff coverage is 100.00%.

❗ Current head e6822d6 differs from pull request most recent head 0ab3664. Consider uploading reports for the commit 0ab3664 to get more accurate results

@@             Coverage Diff             @@
##                main     #1289   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity      1515      1527   +12     
===========================================
  Files            283       286    +3     
  Lines           4901      4946   +45     
  Branches          88        90    +2     
===========================================
+ Hits            4901      4946   +45     
Impacted Files Coverage Δ
...astructure/primary/rest/GitHubActionsResource.java 100.00% <ø> (ø)
...e/infrastructure/primary/rest/AngularResource.java 100.00% <ø> (ø)
...ore/infrastructure/primary/rest/ReactResource.java 100.00% <ø> (ø)
...re/infrastructure/primary/rest/SvelteResource.java 100.00% <ø> (ø)
.../core/infrastructure/primary/rest/VueResource.java 100.00% <ø> (ø)
...istory/infrastructure/primary/HistoryResource.java 100.00% <ø> (ø)
...init/infrastructure/primary/rest/InitResource.java 100.00% <ø> (ø)
...r/npm/infrastructure/primary/rest/NpmResource.java 100.00% <ø> (ø)
...pster/lite/generator/project/domain/Constants.java 100.00% <ø> (ø)
...astructure/primary/rest/FrontendMavenResource.java 100.00% <ø> (ø)
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 349493c...0ab3664. Read the comment docs.

@hdurix hdurix enabled auto-merge April 8, 2022 15:47
@hdurix hdurix merged commit f201f98 into jhipster:main Apr 8, 2022
@pascalgrimaud
Copy link
Member

I think the auto merged is broken as it didn't wait the CI to finish, that's why the current CI failed
I'll have a look once at home

@hdurix hdurix deleted the rest-naming-convention branch August 4, 2022 13:02
@hdurix
Copy link
Member Author

hdurix commented Aug 4, 2022

@pascalgrimaud
Copy link
Member

@hdurix : approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REST-compliance] Naming convention for APIs
2 participants