Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pinia for vue 3 #1188

Merged
merged 1 commit into from
Apr 3, 2022
Merged

Add pinia for vue 3 #1188

merged 1 commit into from
Apr 3, 2022

Conversation

seraphinandrieux
Copy link
Contributor

@seraphinandrieux seraphinandrieux marked this pull request as draft March 29, 2022 08:33
@seraphinandrieux seraphinandrieux force-pushed the add-pinia branch 2 times, most recently from b9b2492 to bb68af5 Compare March 29, 2022 08:36
@codecov
Copy link

codecov bot commented Mar 29, 2022 •
edited
Loading

Codecov Report

Merging #1188 (2a1d658) into main (5097fc4) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##                main     #1188   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity      1487      1497   +10     
===========================================
  Files            282       282           
  Lines           4808      4829   +21     
  Branches          88        88           
===========================================
+ Hits            4808      4829   +21
Impacted Files Coverage Δ
...pster/lite/generator/project/domain/Constants.java 100.00% <ø> (ø)
...nt/vue/core/application/VueApplicationService.java 100.00% <100.00%> (ø)
...ter/lite/generator/client/vue/core/domain/Vue.java 100.00% <100.00%> (ø)
...rator/client/vue/core/domain/VueDomainService.java 100.00% <100.00%> (ø)
.../core/infrastructure/primary/rest/VueResource.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5097fc4...2a1d658. Read the comment docs.

@seraphinandrieux seraphinandrieux marked this pull request as ready for review March 29, 2022 12:32
@seraphinandrieux seraphinandrieux force-pushed the add-pinia branch 3 times, most recently from a6539f1 to 4056fce Compare April 3, 2022 07:49
pascalgrimaud
pascalgrimaud requested changes Apr 3, 2022
View reviewed changes
Copy link
Member

@pascalgrimaud pascalgrimaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few last comments and it would be good

@pascalgrimaud pascalgrimaud merged commit bcdd8fd into jhipster:main Apr 3, 2022
@seraphinandrieux
Copy link
Contributor Author

$200 bounty claimed => https://opencollective.com/generator-jhipster/expenses/70882

@pascalgrimaud
Copy link
Member

@seraphinandrieux : approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalgrimaud pascalgrimaud pascalgrimaud approved these changes

Assignees
No one assigned
Labels
area: feature request 💡 client: vue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[VueJS] Add Pinia into Vue generator + generated
2 participants
@seraphinandrieux @pascalgrimaud