Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refacto: implicit return #11852

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Refacto: implicit return #11852

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 8 additions & 24 deletions src/main/webapp/app/module/primary/landscape/Landscape.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,9 +259,7 @@ export default defineComponent({
),
});

const isFeature = (element: LandscapeElement): boolean => {
return element instanceof LandscapeFeature;
};
const isFeature = (element: LandscapeElement): boolean => element instanceof LandscapeFeature;

const landscapeClass = (): string => {
const hasEmphasizedModule = emphasizedModule.value !== undefined;
Expand Down Expand Up @@ -384,9 +382,7 @@ export default defineComponent({
return '';
};

const flavorClass = (): string => {
return ' ' + modeClass();
};
const flavorClass = (): string => ' ' + modeClass();

const searchHighlightClass = (module: LandscapeElementId): string => {
return highlightedModule.value
Expand Down Expand Up @@ -449,17 +445,11 @@ export default defineComponent({
}
};

const isSelectable = (module: ModuleSlug): boolean => {
return landscapeValue().isSelectable(module);
};
const isSelectable = (module: ModuleSlug): boolean => landscapeValue().isSelectable(module);

const disabledNewApplication = (): boolean => {
return disabledApplication() || landscapeValue().noNotAppliedSelectedModule();
};
const disabledNewApplication = (): boolean => disabledApplication() || landscapeValue().noNotAppliedSelectedModule();

const disabledAllApplication = (): boolean => {
return disabledApplication();
};
const disabledAllApplication = (): boolean => disabledApplication();

const disabledApplication = (): boolean => {
if (operationInProgress.value) {
Expand All @@ -477,23 +467,17 @@ export default defineComponent({
return missingMandatoryProperty();
};

const selectedNewModulesCount = (): number => {
return landscapeValue().notAppliedSelectedModulesCount();
};
const selectedNewModulesCount = (): number => landscapeValue().notAppliedSelectedModulesCount();

const selectedModulesCount = (): number => {
return landscapeValue().selectedModulesCount();
};
const selectedModulesCount = (): number => landscapeValue().selectedModulesCount();

const missingMandatoryProperty = () => {
return selectedModulesProperties().some(
property => property.mandatory && empty(moduleParametersValues.value.get(property.key)) && empty(property.defaultValue),
);
};

const selectedModulesProperties = (): ModulePropertyDefinition[] => {
return landscapeValue().selectedModulesProperties();
};
const selectedModulesProperties = (): ModulePropertyDefinition[] => landscapeValue().selectedModulesProperties();

const updateModuleCommit = (commit: boolean) => {
commitModule = commit;
Expand Down