Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Tikui generated style #11040

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

Gnuk
Copy link
Collaborator

@Gnuk Gnuk commented Oct 3, 2024

No description provided.

@Gnuk
Copy link
Collaborator Author

Gnuk commented Oct 3, 2024

I'am starting to improve generated style from Tikui, I propose you this draft.

murdos
murdos previously approved these changes Oct 3, 2024
@Gnuk Gnuk force-pushed the improve-tikui-style branch 2 times, most recently from 9f9f442 to d6a700f Compare October 4, 2024 13:20
@Gnuk Gnuk marked this pull request as ready for review October 4, 2024 13:21
DamnClin
DamnClin previously approved these changes Oct 5, 2024
Copy link
Collaborator

@DamnClin DamnClin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @pascalgrimaud I think this deserve a Bounty. WDYT?

@Gnuk Gnuk force-pushed the improve-tikui-style branch from d6a700f to 1d0f5c0 Compare October 5, 2024 20:12
@pascalgrimaud pascalgrimaud added $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $500 https://www.jhipster.tech/bug-bounties/ labels Oct 11, 2024
@pascalgrimaud
Copy link
Member

thanks a lot for your great work here @Gnuk !!

@pascalgrimaud pascalgrimaud merged commit 86db258 into jhipster:main Oct 11, 2024
34 checks passed
@Gnuk Gnuk deleted the improve-tikui-style branch October 11, 2024 07:33
@Gnuk
Copy link
Collaborator Author

Gnuk commented Oct 11, 2024

@pascalgrimaud
Copy link
Member

@Gnuk : approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: feature request 💡 $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ theme: client $500 https://www.jhipster.tech/bug-bounties/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants