Move 'base64' and 'slug' shared kernels to 'shared' top-level package #11016
Conversation
| import static tech.jhipster.lite.module.domain.JHipsterModule.*; | ||
| import static tech.jhipster.lite.module.domain.JHipsterModule.artifactId; | ||
| import static tech.jhipster.lite.module.domain.JHipsterModule.from; | ||
| import static tech.jhipster.lite.module.domain.JHipsterModule.groupId; | ||
| import static tech.jhipster.lite.module.domain.JHipsterModule.javaDependency; | ||
| import static tech.jhipster.lite.module.domain.JHipsterModule.mavenPlugin; | ||
| import static tech.jhipster.lite.module.domain.JHipsterModule.moduleBuilder; | ||
| import static tech.jhipster.lite.module.domain.JHipsterModule.pluginExecution; | ||
| import static tech.jhipster.lite.module.domain.JHipsterModule.to; |
There was a problem hiding this comment.
@murdos : The expand import settings are defined in IntelliJ IDEA, or are they handled by Prettier?
There was a problem hiding this comment.
For example, in this commit, it was changed to * instead of staying expanded. I wish there were a way to make this setting the same for everyone.
There was a problem hiding this comment.
Sorry, I had to expand them, otherwise Intellij was not able correctly update imports for feature and module slugs :/
There's a way to uniform imports: we can add a checkstyle rule that forbid * imports.
There was a problem hiding this comment.
It's cool! Do you use the same configuration as mine?
I like this configuration. It expands when there are fewer and put * when there are too many. What do you think about only adding these instructions at CONTRIBUTION.md?
There was a problem hiding this comment.
Honestly, I don't like * at all.
It's often a source of conflicts when multiple developers touch the same file on different branches, and it's not explicit.
I usually forbid them on my projects.
There was a problem hiding this comment.
I can follow your lead as every IDE collapses the import sections. Let's do the checkstyle configuration l😄😉
1ee58e4 to
4f5723c
Compare
Also fixes a few misqualified contexts: maven, gradle and ts-loader