Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(custom-jhlite): setup custom npm and maven version reader to handle custom npm/java dependencies #10896

Merged
merged 16 commits into from
Sep 20, 2024
Merged

feature(custom-jhlite): setup custom npm and maven version reader to handle custom npm/java dependencies #10896

merged 16 commits into from
Sep 20, 2024

Conversation

murdos
Copy link
Contributor

@murdos murdos commented Sep 18, 2024 •
edited
Loading

Fixes #10850 and fixes #10851

@murdos murdos force-pushed the custom-jhlite-npm-dependencies branch from 250e63b to 6139e48 Compare September 18, 2024 11:29
murdos added 11 commits September 19, 2024 00:13
@murdos
chore: remove unnecessary addition of basePackage to context, it's al…
705014f 
…ready there by default
@murdos
feat(project-base-name): support uppercase computation
82f7322
@murdos
feat(custom-jhlite): add tech.jhipster.lite.project steps to cucumber…
a38b8df 
… glue

These steps are also useful for testing modules generation
@murdos
feat(custom-jhlite): report enhancements from cucumber module to Cucu…
18a1722 
…mberConfiguration
@murdos
feature(custom-jhlite): setup custom npm version source and associate…
69726a2 
…d reader to handle custom npm dependencies

Fixes jhipster#10851
@murdos
test(custom-jhlite): use a camel cased base name to have a better tes…
44f5631 
…t case
@murdos
refactor(custom-jhlite): split different features into different buil…
5c19d90 
…der methods
@murdos
chore(custom-jhlite): add unit test for custom npm version source reader
7b89906 
This is necessary for having full code coverage
@murdos
refactor: split maven dependency reader: the actual reader, and this …
ef0799f 
…spring component used by jhlite generator for reading its own pom.xml

This will allow to use the reader in custom jhlite generators. See jhipster#10850
@murdos
refactor(custom-jhlite): rename shared package 'npm' to 'dependencies'
26f3c77 
In preparation for the handling of maven version readers.
@murdos
feature(custom-jhlite): setup custom maven version reader to handle c…
3660710 
…ustom maven dependencies

Fixes jhipster#10850
@murdos murdos force-pushed the custom-jhlite-npm-dependencies branch from dad5d50 to ce67833 Compare September 18, 2024 22:13
@murdos murdos changed the title feature(custom-jhlite): setup custom npm version source and associated reader to handle custom npm dependencies feature(custom-jhlite): setup custom npm and maven version reader to handle custom npm/java dependencies Sep 18, 2024
@murdos murdos force-pushed the custom-jhlite-npm-dependencies branch from ce67833 to 254ed22 Compare September 18, 2024 22:24
@murdos
Copy link
Contributor Author

murdos commented Sep 19, 2024

FYI I've updated jhipster/jhipster-lite-extension#85 that shows the purpose of this PR.
The first commit (jhipster/jhipster-lite-extension@f065324) corresponds to the application of the changes of the custom-jhlite module made in this PR.

@pascalgrimaud pascalgrimaud added $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $500 https://www.jhipster.tech/bug-bounties/ labels Sep 19, 2024
renanfranca
renanfranca approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@renanfranca renanfranca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work once again, @murdos! I am used to this pattern of having different commits for features and implementation. It's so hard to review everything in a single commit 😅

@murdos murdos merged commit 884915a into jhipster:main Sep 20, 2024
34 checks passed
@murdos murdos deleted the custom-jhlite-npm-dependencies branch September 20, 2024 05:06
@murdos
Copy link
Contributor Author

murdos commented Sep 20, 2024

Thanks for the reviews @renanfranca, it's really appreciated! 👍

@renanfranca
Copy link
Contributor

Thanks for the reviews @renanfranca, it's really appreciated! 👍

You're welcome 😊

@murdos
Copy link
Contributor Author

murdos commented Dec 20, 2024

@pascalgrimaud : bounty claimed https://opencollective.com/generator-jhipster/expenses/232614

@pascalgrimaud
Copy link
Member

@murdos : approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renanfranca renanfranca renanfranca approved these changes

@pascalgrimaud pascalgrimaud Awaiting requested review from pascalgrimaud

Assignees
No one assigned
Labels
area: feature request 💡 $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ generator: internal $500 https://www.jhipster.tech/bug-bounties/
Projects
None yet
Milestone
No milestone
3 participants
@murdos @renanfranca @pascalgrimaud