Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a small documentation for ApprovalTests #10774

Merged
merged 9 commits into from
Sep 12, 2024
Merged

Conversation

Harsh4902
Copy link
Contributor

Signed-off-by: Harsh4902 <harshparmar4902@gmail.com>
Signed-off-by: Harsh4902 <harshparmar4902@gmail.com>
Signed-off-by: Harsh4902 <harshparmar4902@gmail.com>
@Harsh4902
Copy link
Contributor Author

@murdos How can I fix this formatting error?

@fabienpuissant
Copy link
Collaborator

@murdos How can I fix this formatting error?

npm run prettier:format 😃

@pascalgrimaud pascalgrimaud added area: documentation 📚 Improvements or additions to documentation theme: tests and removed area: triage labels Sep 9, 2024
@pascalgrimaud
Copy link
Member

pascalgrimaud commented Sep 9, 2024

all the code is formatted automatically using husky git hook (after you commit), but you need to launch npm ci the first time you clone the project, then regularly as the dependencies are updated each day

Copy link
Contributor

@murdos murdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new documentation is not included in the generated application.
You need to generates it.
Start with completing existing tests for this module, as done with the other similar module:

And then make the test pass :) (Hint: study the PropertyBasedTestingModuleFactory to understand what you should do)

Signed-off-by: Harsh4902 <harshparmar4902@gmail.com>
Signed-off-by: Harsh4902 <harshparmar4902@gmail.com>
@Harsh4902 Harsh4902 requested a review from murdos September 12, 2024 16:07
@murdos murdos merged commit a868aea into jhipster:main Sep 12, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation 📚 Improvements or additions to documentation theme: tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a small documentation for ApprovalTests
4 participants