Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace @import by @use inside Tikui style #10755

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Replace @import by @use inside Tikui style #10755

merged 1 commit into from
Sep 4, 2024

Conversation

qmonmert
Copy link
Contributor

@qmonmert qmonmert commented Sep 4, 2024

Fix #10754

@qmonmert qmonmert marked this pull request as ready for review September 4, 2024 13:06
renanfranca
renanfranca approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@renanfranca renanfranca left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work @qmonmert ! LGTM ;) edited

Good to know that it's possible to use @use without explicitly setting an alias with as name

@murdos murdos merged commit f005fad into jhipster:main Sep 4, 2024
34 checks passed
@pascalgrimaud pascalgrimaud changed the title Replace @import by @use inside Tikui style Replace @import by @use inside Tikui style Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renanfranca renanfranca renanfranca approved these changes

@Gnuk Gnuk Awaiting requested review from Gnuk

@pascalgrimaud pascalgrimaud Awaiting requested review from pascalgrimaud

Assignees
No one assigned
Labels
area: enhancement 🔧 generator: internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace @import by @use inside Tikui style
3 participants
@qmonmert @renanfranca @murdos