parametrize the preset json file name in the spring boot configuration

[renanfranca]

Fix #10553

[murdos]

What exactly has changed since #10578?

[renanfranca]

What exactly has changed since #10578?

I tagged you in the code comments with explanations. Let me know if it was enough 👍

[murdos]

I tagged you in the code comments with explanations. Let me know if it was enough 👍

I have not received any notification. Maybe you've started a review session that you have not finished?

[renanfranca]

I have not received any notification. Maybe you've started a review session that you have not finished?

@murdos: Maybe I don't know how to start a review properly when I am the PR owner. I'll play around with two GitHub accounts in another repository to master it, hahaha ;)

Changes since the previous PR #10578

The bug was fixed by adding this parameter:

@Configuration 
@EnableConfigurationProperties(JHipsterPresetFileProperties.class) 
class JHipsterPresetFilePropertiesConfiguration { 
  
  @Bean 
  JHipsterPresetFile jhipsterPresetFile(JHipsterPresetFileProperties presetFileProperties) { 
    return new JHipsterPresetFile(PresetName.from(presetFileProperties.getName())); 
  } 
}

This was the previous bugged code:

@Configuration 
@EnableConfigurationProperties(JHipsterPresetFileProperties.class) 
class JHipsterPresetFilePropertiesConfiguration { 
  
  @Bean 
  JHipsterPresetFile jhipsterPresetFile() { 
    return new JHipsterPresetFile(new JHipsterPresetFileProperties().getName()); 
  } 
}

I used a value object instead of a string and refactored the code to fit that change:

package tech.jhipster.lite.project.domain.resource; 
  
import tech.jhipster.lite.project.domain.preset.PresetName; 
import tech.jhipster.lite.shared.error.domain.Assert; 
  
public record JHipsterPresetFile(PresetName name) { 
  public JHipsterPresetFile { 
    Assert.notNull("name", name); 
  } 
}

[pascalgrimaud]

in fact, I would use directly @Value in repository, to inject the property, no need to use a Configuration and a Bean

[renanfranca]

#10590 (comment)

@murdos , please WDYT about it? (I tagged here, because I am not sure if you received notification 😅)