Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for Router (improve Sonar) #10505

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Add tests for Router (improve Sonar) #10505

merged 1 commit into from
Aug 5, 2024

Conversation

qmonmert
Copy link
Contributor

@qmonmert qmonmert commented Aug 4, 2024 •
edited
Loading

Remove src/main/webapp/app/router/index.ts from exclusion files on sonar-project.properties

@qmonmert qmonmert changed the title Add tests for Router Add tests for Router (improve Sonar) Aug 4, 2024
@qmonmert qmonmert marked this pull request as ready for review August 4, 2024 16:18
@murdos
Copy link
Contributor

murdos commented Aug 4, 2024

I'm not sure that these tests have a real value.
I agree that we should not exclude the router code from sonar coverage, but we should rather merge the code coverage of the unit and components tests, that will allow indirectly verify all routes are used.

@murdos
Copy link
Contributor

murdos commented Aug 5, 2024

Anyway, I think we can merge this PR, and re-evaluate when/if we merge frontend code coverage.

@murdos murdos merged commit f06dd74 into jhipster:main Aug 5, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murdos murdos murdos approved these changes

@pascalgrimaud pascalgrimaud Awaiting requested review from pascalgrimaud

Assignees
No one assigned
Labels
area: enhancement 🔧
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qmonmert @murdos