display preset options at landscape mode #10485
Conversation
|
Here is a demo of using the preset configurations: preset-configuration-demo.mp4 |
|
Good feature but I think this is taking too much space and will be annoying for people on small screens. We should probably do something like the minimap for this feature (and probably make minimap and preset smaller with just an icon) |
@DamnClin: Please let me know if it is okay now. I attached a new demo video below. Thank you for taking a look. preset-configuration-hide-option-demo.mp4 |
abe4431 to
6651b76
Compare
9f0fbf0 to
7301ef8
Compare
|
Is it ready for being merged? There are probably other small improvements but it can be done in another PRs |
src/main/webapp/app/module/secondary/RestPresetModuleToApply.ts
Outdated
Show resolved
Hide resolved
src/test/webapp/unit/module/primary/landscape/LandscapePresetConfigurationComponent.spec.ts
Outdated
Show resolved
Hide resolved
7301ef8 to
a768492
Compare
|
Thank you very much for taking the time to review @qmonmert ! I appreciated it 💙😃 |
src/test/webapp/unit/module/primary/landscape/LandscapeComponent.spec.ts
Outdated
Show resolved
Hide resolved
src/test/webapp/unit/module/primary/landscape/LandscapeComponent.spec.ts
Outdated
Show resolved
Hide resolved
src/test/webapp/unit/module/primary/landscape/LandscapeComponent.spec.ts
Outdated
Show resolved
Hide resolved
👍 |
…t.ts component name
…andscape component
… with null when deselecting preset
…to achieve 100% code coverage
…ule is deselected
…o select a new non-selectable module
…nent display style
…eset-configuration
…eption when reading preset.json as it now exists in src/main/resources
… (`??`) instead of a logical or (`||`), as it is a safer operator
…reset configuration feature
…ix from helper function
…ary adjective from test name
a768492 to
3a99714
Compare
…ring preset dropdown change event
Fix #10379
there is a to-do at this issue description.