Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: Remove unused code in test file #10390

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Angular: Remove unused code in test file #10390

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions ...ster/lite/generator/client/angular/security/oauth2/domain/AngularOauth2ModuleFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ public class AngularOauth2ModuleFactory {
private static final String TEST_IMPORTS =
"""
import { By } from '@angular/platform-browser';
import { Oauth2AuthService } from './auth/oauth2-auth.service';
import LoginComponent from './login/login.component';
""";
private static final ElementReplacer TEST_NEEDLE = lineAfterRegex("^\\s+it\\('should have appName',[^}]+\\}\\);");
Expand Down Expand Up @@ -92,20 +91,6 @@ public class AngularOauth2ModuleFactory {

private static final ElementReplacer INJECT_NEEDLE = text("import { Component, OnInit, signal } from '@angular/core';");

private static final ElementReplacer BEFORE_EACH_NEEDLE = lineAfterRegex("comp = fixture.componentInstance;");

private static final String TESTBED_INJECT_OAUTH2_AUTH_SERVICE =
"""
oauth2AuthService = TestBed.inject(Oauth2AuthService);\
""";

private static final ElementReplacer TEST_APP_COMPONENT = lineAfterRegex("let comp: AppComponent;");

private static final String DECLARE_INJECT_OAUTH2_AUTH_SERVICE =
"""
let oauth2AuthService: Oauth2AuthService;\
""";

private static final String LOGIN_COMPONENT_TEST =
"""

Expand Down Expand Up @@ -178,8 +163,6 @@ public JHipsterModule buildModule(JHipsterModuleProperties properties) {
.in(path("src/main/webapp/app/app.component.spec.ts"))
.add(fileStart(), TEST_IMPORTS)
.add(TEST_NEEDLE, LOGIN_COMPONENT_TEST.indent(indentation.spacesCount() * 2))
.add(BEFORE_EACH_NEEDLE, TESTBED_INJECT_OAUTH2_AUTH_SERVICE)
.add(TEST_APP_COMPONENT, DECLARE_INJECT_OAUTH2_AUTH_SERVICE)
.and()
.in(path("src/main/webapp/app/app.component.html"))
.add(MENU_NEEDLE, indentation.spaces() + "<jhi-login></jhi-login>")
Expand Down